Bug 226541

Summary: games/minetest: add clang fixes, missing dependencies, luajit 2.1 compatibility
Product: Ports & Packages Reporter: Val Packett <val>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: val
Priority: --- Flags: bugzilla: maintainer-feedback? (amdmi3)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 225342    
Attachments:
Description Flags
minetest-fixes.patch none

Description Val Packett 2018-03-11 21:59:45 UTC
Created attachment 191433 [details]
minetest-fixes.patch

Dependencies suggested by stage-qa + fix for luajit 2.1 + fixes for C++ errors that were happening with base clang in -CURRENT:

src/content_mapblock.cpp:46:24: error: constexpr variable cannot have non-literal type 'v3s16 const[8]'                               
static constexpr v3s16 light_dirs[8] = {                                                                                                
                       ^                                                                                          
/usr/local/include/irrlicht/vector3d.h:22:8: note: 'vector3d<short>' is not literal because it is not an aggregate and has no constexpr
constructors other than copy or move constructors
        class vector3d 

and

src/content_mapblock.cpp:358:38: error: use of undeclared identifier 'NULL'                                                             
                drawCuboid(box, tiles, tile_count, NULL, txc);                                                                          
                                                   ^                                                                                    
/usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'                                                                        
#define NULL    nullptr                                                                                                                 
                ^                                                                                                                       
src/util/cpp11.h:29:17: note: expanded from macro 'nullptr'                                                                             
#define nullptr NULL                                                                                                                    
                ^                                                                          
src/content_mapblock.cpp:1193:29: error: use of undeclared identifier 'NULL'                                                         
                drawAutoLightedCuboid(*i, NULL, tiles, 6);                                                                              
                                          ^                                                                                             
/usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'                                                                        
#define NULL    nullptr                                                                                                                 
                ^                                                                                                                       
src/util/cpp11.h:29:17: note: expanded from macro 'nullptr'                                                                             
#define nullptr NULL
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2019-12-05 20:50:02 UTC
No longer actual for 5.1.0