Bug 226707

Summary: irc/weechat Update to 2.1
Product: Ports & Packages Reporter: Greg Fitzgerald <gregf>
Component: Individual Port(s)Assignee: Bernard Spil <brnrd>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (brnrd)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
weechat.diff
brnrd: maintainer-approval-
weechat-updated.diff none

Description Greg Fitzgerald 2018-03-18 19:29:43 UTC
Created attachment 191610 [details]
weechat.diff
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2018-03-18 19:53:26 UTC
Comment on attachment 191610 [details]
weechat.diff

Errors in make check-plist with this patch

2.1 adds -headless which needs to be accounted for
Comment 2 Greg Fitzgerald 2018-03-18 20:07:02 UTC
Oops still new to doing ports, forgot to check that first. Sorry here's a udpated patch.
Comment 3 Greg Fitzgerald 2018-03-18 20:07:53 UTC
Created attachment 191613 [details]
weechat-updated.diff

Fixes earlier patch to include new plist files.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-03-18 20:50:37 UTC
A commit references this bug:

Author: brnrd
Date: Sun Mar 18 20:50:04 UTC 2018
New revision: 464954
URL: https://svnweb.freebsd.org/changeset/ports/464954

Log:
  irc/weechat: Update to 2.1

  PR:		226707
  Reported by:	Greg Fitzgerald <gregf hugops pw>

Changes:
  head/irc/weechat/Makefile
  head/irc/weechat/distinfo
  head/irc/weechat/pkg-plist
Comment 5 Bernard Spil freebsd_committer freebsd_triage 2018-03-18 20:55:44 UTC
(In reply to Greg Fitzgerald from comment #2)
Sorry, Greg... Updated the port myself.

I was a bit terse in my response, but was happy with your heads-up and the attempted patch!

If you check the diff for your updated patch, you'll see that it wreaks havoc in pkg-plist. Not sure how you updated the pkg-plist, simple make makeplist? I've manually added the bits to the pkg-plist file after adding the HEADLESS option.

Jump into #freebsd-ports on Freenode or #bsdports on EFNet irc, there's usually people around who can help out.

Before committing a patch, please make sure that `make check-plist` returns no problems and `portlint -AC` hasn't grown. Building with poudriere is also a required step (multiple arch and FreeBSD versions)