Bug 226707 - irc/weechat Update to 2.1
Summary: irc/weechat Update to 2.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernard Spil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-18 19:29 UTC by Greg Fitzgerald
Modified: 2018-03-18 20:55 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (brnrd)

Attachments
weechat.diff (773 bytes, patch)
2018-03-18 19:29 UTC, Greg Fitzgerald 		brnrd: maintainer-approval-
Details | Diff
weechat-updated.diff (8.31 KB, patch)
2018-03-18 20:07 UTC, Greg Fitzgerald 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Fitzgerald 2018-03-18 19:29:43 UTC 
Created attachment 191610 [details]
weechat.diff
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2018-03-18 19:53:26 UTC 
Comment on attachment 191610 [details]
weechat.diff

Errors in make check-plist with this patch

2.1 adds -headless which needs to be accounted for
Comment 2 Greg Fitzgerald 2018-03-18 20:07:02 UTC 
Oops still new to doing ports, forgot to check that first. Sorry here's a udpated patch.
Comment 3 Greg Fitzgerald 2018-03-18 20:07:53 UTC 
Created attachment 191613 [details]
weechat-updated.diff

Fixes earlier patch to include new plist files.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-03-18 20:50:37 UTC 
A commit references this bug:

Author: brnrd
Date: Sun Mar 18 20:50:04 UTC 2018
New revision: 464954
URL: https://svnweb.freebsd.org/changeset/ports/464954

Log:
  irc/weechat: Update to 2.1

  PR:		226707
  Reported by:	Greg Fitzgerald <gregf hugops pw>

Changes:
  head/irc/weechat/Makefile
  head/irc/weechat/distinfo
  head/irc/weechat/pkg-plist
Comment 5 Bernard Spil freebsd_committer freebsd_triage 2018-03-18 20:55:44 UTC 
(In reply to Greg Fitzgerald from comment #2)
Sorry, Greg... Updated the port myself.

I was a bit terse in my response, but was happy with your heads-up and the attempted patch!

If you check the diff for your updated patch, you'll see that it wreaks havoc in pkg-plist. Not sure how you updated the pkg-plist, simple make makeplist? I've manually added the bits to the pkg-plist file after adding the HEADLESS option.

Jump into #freebsd-ports on Freenode or #bsdports on EFNet irc, there's usually people around who can help out.

Before committing a patch, please make sure that `make check-plist` returns no problems and `portlint -AC` hasn't grown. Building with poudriere is also a required step (multiple arch and FreeBSD versions)