|Summary:||ports-mgmt/portlint: Bogus warning WARN: Makefile: sh is already included in SHEBANG_LANG.|
|Product:||Ports & Packages||Reporter:||Yuri Victorovich <yuri>|
|Component:||Individual Port(s)||Assignee:||Joe Marcus Clarke <marcus>|
|Severity:||Affects Only Me||Flags:||bugzilla:
Description Yuri Victorovich 2018-03-18 20:07:12 UTC
Mk/Uses/shebangfix.mk doesn't add 'sh' to SHEBANG_LANG. Testcase: sysutils/DTraceToolkit After removing this line, SHEBANG_LANG doesn't contain "sh": > $ make -V SHEBANG_LANG > bash java ksh perl php python ruby tcl tk And stage-qa breaks.
Comment 1 Joe Marcus Clarke 2018-04-14 17:31:45 UTC
Yeah, this was not a great check. I've improved it in my repo pending the next release.
Comment 2 commit-hook 2018-05-11 21:34:28 UTC
A commit references this bug: Author: marcus Date: Fri May 11 21:33:56 UTC 2018 New revision: 469697 URL: https://svnweb.freebsd.org/changeset/ports/469697 Log: Update to 2.18.0. Enough has happened that it's time for a minor bump. * Fix the check for duplicate SHEBANG_LANG values  * Check to make sure patch files end with newlines  * Allow flavored *_DEPENDS in the DEPENDS section  * Check that kde:4 OR kde:5 is defined with USE_KDE  * Add a check to make sure pkg-descr is at least a certain number of lines  * Fix a couple of typos   * Allow for any *_DEPENDS item in the DEPENDS section and fix a bug in the dependency syntax checking  * Add a check to make sure Python dependencies include a FLAVOR  PR: 226709  226109  226581  227255  227729  227878  227556  225654  Submitted by: tcberner  0mp  Differential Revision: D13723  Changes: head/ports-mgmt/portlint/Makefile head/ports-mgmt/portlint/pkg-descr head/ports-mgmt/portlint/src/portlint.pl
Comment 3 Joe Marcus Clarke 2018-05-11 21:35:36 UTC
Fixed in 2.18.0.