Bug 228203
| Summary: | ports-mgmt/portlint: regression re "make makepatch" | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Gerald Pfeifer <gerald> |
| Component: | Individual Port(s) | Assignee: | Joe Marcus Clarke <marcus> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | Flags: | bugzilla:
maintainer-feedback?
(marcus) |
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
The last was bad. It broke all of the other checks for the patch. So, either the whole patch needs to be read, and then a separate loop is needed for this check or the last needs to be left out. Fixed in 2.18.2. A commit references this bug: Author: marcus Date: Sat May 12 22:14:31 UTC 2018 New revision: 469758 URL: https://svnweb.freebsd.org/changeset/ports/469758 Log: Bump version to 2.18.2. Fix a regression in the mae makepatch check. Make sure only the patch header is checked, but make sure to read in the entire patch file. This regression was introduced in 2.18.0. PR: 228203 Changes: head/ports-mgmt/portlint/Makefile head/ports-mgmt/portlint/src/portlint.pl Super - thanks for the ultra-fast response! Happy to confirm this fixes both issues I've seen/reported. |
PR 202050 was addressed by a patch of mine and marked Closed FIXED on 2015-08-09. With portlint 2.18.0 this returned, and the line I had added is commented as follows: # last; So probably this was done for debugging purposes and missed when releasing? Also, the workaround in patchfiles to avoid this warning no longer works. For a testcase for both issues, "cd $PORTSDIR/lang/gcc8-devel ; portlint -C".