Bug 228896
| Summary: | devel/gnome-vfs: Fails to build with OpenSSL 1.1 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Bernard Spil <brnrd> | ||||||
| Component: | Individual Port(s) | Assignee: | Ben Woods <woodsb02> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | grahamperrin, me, ndowens04, woodsb02 | ||||||
| Priority: | --- | Flags: | woodsb02:
maintainer-feedback-
woodsb02: merge-quarterly+ |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 228865, 231931 | ||||||||
| Attachments: |
|
||||||||
|
Description
Bernard Spil
2018-06-11 19:22:14 UTC
Recent failure log: http://package18.nyi.freebsd.org/data/headamd64PR231931-default/2018-10-04_07h49m12s/logs/errors/gnome-vfs-2.24.4_9.log Created attachment 197877 [details] Fix OpenSSL 1.x build devel/gnome-vfs: * Fix OpenSSL 1.1.X build * Add gnome to USES, while here PR: 228896 Submitted by: Nathan <ndowens@yahoo.com> (In reply to Nathan from comment #2) There are unrelated changes and regressions in this patch (In reply to Antoine Brodin from comment #3) The changes in the other patches besides the patch-libgnomevfs_gnome-vfs-ssl.c are from doing make makepatch. I didn't change the others myself. Just created the vfs-ssl.c one (In reply to Nathan from comment #4) But I'll try to make it where the patch only changes the one that is needed for bug (In reply to Nathan from comment #4) Don't use "make makepatch" after "make patch", it's usually better to make extract pre-patch do-patch hack make makepatch (In reply to Antoine Brodin from comment #6) Thought I did it that way. Don't remember doing make patch before i created it Created attachment 197881 [details] Fix OpenSSL 1.x build devel/gnome-vfs: * Fix OpenSSL 1.1.X build * Add gnome to USES, while here PR: 228896 Submitted by: Nathan <ndowens@yahoo.com> Hi Nathan, Thanks for the submission! Am I correct in saying this patch was obtained from NetBSD [1]? I also note it is in Gentoo, but they attribute NetBSD for the patch [2]. [1] http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/sysutils/gnome-vfs/patches/patch-libgnomevfs_gnome-vfs-ssl.c?rev=1.1&content-type=text/x-cvsweb-markup [2] https://bugs.gentoo.org/592540 Thanks, Ben A commit references this bug: Author: woodsb02 Date: Sat Oct 27 08:19:23 UTC 2018 New revision: 483115 URL: https://svnweb.freebsd.org/changeset/ports/483115 Log: devel/gnome-vfs: Fix OpenSSL 1.1.X build - Patch taken from NetBSD [1] - Add gnome to USES [1] http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/sysutils/gnome-vfs/patches/patch-libgnomevfs_gnome-vfs-ssl.c?rev=1.1&content-type=text/x-cvsweb-markup PR: 228896 Submitted by: Nathan <ndowens@yahoo.com> Reported by: brnrd Approved by: gnome (maintainer timeout) Obtained from: NetBSD MFH: 2018Q4 Changes: head/devel/gnome-vfs/Makefile head/devel/gnome-vfs/files/patch-openssl-1.1 Committed - thanks for the submission! Awaiting approval to merge to the ports quarterly 2018Q4 branch. A commit references this bug: Author: antoine Date: Thu Nov 1 18:22:26 UTC 2018 New revision: 483700 URL: https://svnweb.freebsd.org/changeset/ports/483700 Log: MFH: r483115 devel/gnome-vfs: Fix OpenSSL 1.1.X build - Patch taken from NetBSD [1] - Add gnome to USES [1] http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/sysutils/gnome-vfs/patches/patch-libgnomevfs_gnome-vfs-ssl.c?rev=1.1&content-type=text/x-cvsweb-markup PR: 228896 Submitted by: Nathan <ndowens@yahoo.com> Reported by: brnrd Approved by: gnome (maintainer timeout) Obtained from: NetBSD Changes: _U branches/2018Q4/ branches/2018Q4/devel/gnome-vfs/Makefile branches/2018Q4/devel/gnome-vfs/files/patch-openssl-1.1 Merged to 2018Q4. |