Bug 228900

Summary:	security/krb5: Fails to build with OpenSSL 1.1
Product:	Ports & Packages	Reporter:	Bernard Spil <brnrd>
Component:	Individual Port(s)	Assignee:	Cy Schubert <cy>
Status:	Closed FIXED
Severity:	Affects Only Me	Flags:	bugzilla: maintainer-feedback? (cy)
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any
Bug Depends on:
Bug Blocks:	228865

Description Bernard Spil freebsd_committer

2018-06-11 19:36:54 UTC

> In file included from ./pkinit_crypto_openssl.h:52:
> /usr/local/include/openssl/asn1_mac.h:10:2: error: "This file is obsolete; please update your software."
> #error "This file is obsolete; please update your software."

During BSDCan 2018 the intention to update OpenSSL in base to 1.1.x branch was documented.

Intention is to update 12-STABLE to current 1.1.0 and subsequently update it to 1.1.1 when that is released. 

Poudriere log: https://keg.brnrd.eu/data/111amd64-default-openssl110/2018-06-11_10h42m37s/logs/errors/krb5-1.16.1.log

Comment 1 Cy Schubert freebsd_committer

2018-06-12 01:22:12 UTC

The patches supplied in PR 217027, committed in r433966 and r433967, were incorrect, reversed logic. Pointy hat to brnrd, All but krb5-114 are fixed. Will apply the same

Comment 2 commit-hook freebsd_committer

2018-06-12 03:42:54 UTC

A commit references this bug:

Author: cy
Date: Tue Jun 12 03:42:20 UTC 2018
New revision: 472227
URL: https://svnweb.freebsd.org/changeset/ports/472227

Log:
  Fix logic from patch supplied in PR 217027, committed in
  r433966 and r433967.

  PR:		228900

Changes:
  head/security/krb5-115/Makefile
  head/security/krb5-115/files/patch-plugins_preauth_pkinit_pkinit__crypto__openssl.h
  head/security/krb5-116/Makefile
  head/security/krb5-116/files/patch-plugins_preauth_pkinit_pkinit__crypto__openssl.h
  head/security/krb5-devel/Makefile
  head/security/krb5-devel/files/patch-plugins_preauth_pkinit_pkinit__crypto__openssl.h

Comment 3 commit-hook freebsd_committer

2018-06-12 03:42:56 UTC

A commit references this bug:

Author: cy
Date: Tue Jun 12 03:42:25 UTC 2018
New revision: 472228
URL: https://svnweb.freebsd.org/changeset/ports/472228

Log:
  krb5-114 is deprecated and scheduled for deletion at the end of this
  year. Mark broken with OpenSSL >= 1.1.0.

  PR:		228900

Changes:
  head/security/krb5-114/Makefile

Comment 4 Cy Schubert freebsd_committer

2018-06-12 03:45:44 UTC

Fixed in all krb5 ports except krb5-114, as it is deprecated and scheduled for removal anyway.

Comment 5 Bernard Spil freebsd_committer

2018-06-12 13:56:04 UTC

Thanks for the quick fixing!

Comment 6 Cy Schubert freebsd_committer

2018-06-12 13:58:35 UTC

I should have more thoroughly tested it myself, bad on my part. I don't test as rigorously when a patch is submitted by another committer.