Bug 229147
| Summary: | security/openssh-portable: fix incorrect use_pam initialization | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Robert Schulze <rs> | ||||
| Component: | Individual Port(s) | Assignee: | Bryan Drewery <bdrewery> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(bdrewery) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: bdrewery Date: Tue Jun 19 15:42:32 UTC 2018 New revision: 472797 URL: https://svnweb.freebsd.org/changeset/ports/472797 Log: Fix nologin check when PAM option is disabled in the port. PR: 229147 Submitted by: Robert Schulze <rs@bytecamp.net> Changes: head/security/openssh-portable/files/patch-servconf.c A commit references this bug: Author: bdrewery Date: Tue Jun 19 15:42:54 UTC 2018 New revision: 472798 URL: https://svnweb.freebsd.org/changeset/ports/472798 Log: Forgot PORTREVISION bump for r472797. PR: 229147 Changes: head/security/openssh-portable/Makefile Thank you! A commit references this bug: Author: bdrewery Date: Tue Jun 19 15:44:42 UTC 2018 New revision: 472800 URL: https://svnweb.freebsd.org/changeset/ports/472800 Log: MFH: r472796 r472797 r472798 Add lost metadata on why this patch exists Fix nologin check when PAM option is disabled in the port. PR: 229147 Submitted by: Robert Schulze <rs@bytecamp.net> Forgot PORTREVISION bump for r472797. PR: 229147 Approved by: portmgr (implicit) Changes: _U branches/2018Q2/ branches/2018Q2/security/openssh-portable/Makefile branches/2018Q2/security/openssh-portable/files/patch-servconf.c A commit references this bug: Author: bdrewery Date: Tue Jun 19 15:44:42 UTC 2018 New revision: 472800 URL: https://svnweb.freebsd.org/changeset/ports/472800 Log: MFH: r472796 r472797 r472798 Add lost metadata on why this patch exists Fix nologin check when PAM option is disabled in the port. PR: 229147 Submitted by: Robert Schulze <rs@bytecamp.net> Forgot PORTREVISION bump for r472797. PR: 229147 Approved by: portmgr (implicit) Changes: _U branches/2018Q2/ branches/2018Q2/security/openssh-portable/Makefile branches/2018Q2/security/openssh-portable/files/patch-servconf.c |
Created attachment 194396 [details] rebuilt patchfile Due to the patch files/patch-servconf.c, the configuration variable option->use_pam is statically initialized with the value 1. This in fact disables nologin behaviour when PAM is NOT selected during build. See line 1516 in session.c. I've edited servconf.c and rebuild the patch with "make makepatch". The whole patchfile is attached (3 lines added). Tests resulted in the correct behaviour. Regards, Robert Schulze