Bug 229147 - security/openssh-portable: fix incorrect use_pam initialization
Summary: security/openssh-portable: fix incorrect use_pam initialization
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-19 09:46 UTC by Robert Schulze
Modified: 2018-06-19 15:45 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bdrewery)

Attachments
rebuilt patchfile (1.30 KB, text/plain)
2018-06-19 09:46 UTC, Robert Schulze 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Schulze 2018-06-19 09:46:03 UTC 
Created attachment 194396 [details]
rebuilt patchfile

Due to the patch files/patch-servconf.c, the configuration variable option->use_pam is statically initialized with the value 1. This in fact disables nologin behaviour when PAM is NOT selected during build. See line 1516 in session.c.

I've edited servconf.c and rebuild the patch with "make makepatch". The whole patchfile is attached (3 lines added). Tests resulted in the correct behaviour.

Regards,
Robert Schulze
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-06-19 15:43:00 UTC 
A commit references this bug:

Author: bdrewery
Date: Tue Jun 19 15:42:32 UTC 2018
New revision: 472797
URL: https://svnweb.freebsd.org/changeset/ports/472797

Log:
  Fix nologin check when PAM option is disabled in the port.

  PR:		229147
  Submitted by:	Robert Schulze <rs@bytecamp.net>

Changes:
  head/security/openssh-portable/files/patch-servconf.c
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-06-19 15:43:02 UTC 
A commit references this bug:

Author: bdrewery
Date: Tue Jun 19 15:42:54 UTC 2018
New revision: 472798
URL: https://svnweb.freebsd.org/changeset/ports/472798

Log:
  Forgot PORTREVISION bump for r472797.

  PR:		229147

Changes:
  head/security/openssh-portable/Makefile
Comment 3 Bryan Drewery freebsd_committer freebsd_triage 2018-06-19 15:43:33 UTC 
Thank you!
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-06-19 15:45:06 UTC 
A commit references this bug:

Author: bdrewery
Date: Tue Jun 19 15:44:42 UTC 2018
New revision: 472800
URL: https://svnweb.freebsd.org/changeset/ports/472800

Log:
  MFH: r472796 r472797 r472798

  Add lost metadata on why this patch exists

  Fix nologin check when PAM option is disabled in the port.

  PR:		229147
  Submitted by:	Robert Schulze <rs@bytecamp.net>

  Forgot PORTREVISION bump for r472797.

  PR:		229147

  Approved by:	portmgr (implicit)

Changes:
_U  branches/2018Q2/
  branches/2018Q2/security/openssh-portable/Makefile
  branches/2018Q2/security/openssh-portable/files/patch-servconf.c
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-06-19 15:45:08 UTC 
A commit references this bug:

Author: bdrewery
Date: Tue Jun 19 15:44:42 UTC 2018
New revision: 472800
URL: https://svnweb.freebsd.org/changeset/ports/472800

Log:
  MFH: r472796 r472797 r472798

  Add lost metadata on why this patch exists

  Fix nologin check when PAM option is disabled in the port.

  PR:		229147
  Submitted by:	Robert Schulze <rs@bytecamp.net>

  Forgot PORTREVISION bump for r472797.

  PR:		229147

  Approved by:	portmgr (implicit)

Changes:
_U  branches/2018Q2/
  branches/2018Q2/security/openssh-portable/Makefile
  branches/2018Q2/security/openssh-portable/files/patch-servconf.c