Bug 229961
| Summary: | [update] devel/libconfig: update to 1.7.2 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Maxim Filimonov <che> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | fernape, ntarmos | ||||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(ntarmos) |
||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
The port needs an update. Warning: may break things (presumably tox). The poudriere log follows. Created attachment 195369 [details]
poudriere log
Created attachment 195372 [details]
the patch [2]
Take Hi Maxim, Thanks for the patch :-) I have a question though: is the update correct? the static library is not built anymore and the shared library changes its name from libconfig to liblibconfig Hello Fernando, Well, I didn't patch it much, so it does exactly what it does. Didn't find the .a file anywhere, and poudriere doesn't say there are any orphaned files in the staging dir. Might have to patch it, tho; the only problem is, I don't know what exactly to patch yet. Created attachment 195449 [details]
Proposed patch
New patch that uses GNU autotools for building.
(In reply to Maxim Filimonov from comment #6) The problem is that the change in the name can cause breakage. I don't know why the CMake build does that, but if building with GNU autotools, the generated artifacts are similar to the ones generated before (libconfig.so instead of liblibconfig.so, libconfig.a generated too...). So I propose a new patch to update the port. Cheers I could patch the CMake configs so that they'd provide the same artifacts. (In reply to Maxim Filimonov from comment #9) I rather avoid adding patches to the port. Building with GNU autotools seems to work fine out of the box. A commit references this bug: Author: fernape Date: Mon Aug 6 17:22:41 UTC 2018 New revision: 476517 URL: https://svnweb.freebsd.org/changeset/ports/476517 Log: devel/libconfig: update to 1.7.2 * Change to USE_GH * Bump PORTREVISION of dependant ports. Committing after maintainer timeout PR: 229961 Submitted by: che@bein.link Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D16442 Changes: head/astro/siril/Makefile head/audio/shairport-sync/Makefile head/audio/umurmur/Makefile head/databases/ateam_mysql_ldap_auth/Makefile head/databases/zabbix22-libzbxpgsql/Makefile head/databases/zabbix3-libzbxpgsql/Makefile head/databases/zabbix32-libzbxpgsql/Makefile head/databases/zabbix34-libzbxpgsql/Makefile head/devel/libconfig/Makefile head/devel/libconfig/distinfo head/devel/libconfig/pkg-plist head/lang/ldc/Makefile head/net/sslh/Makefile head/net-im/telegram/Makefile head/net-im/tox/Makefile head/net-im/toxic/Makefile head/security/cvechecker/Makefile head/security/razorback-api/Makefile head/x11-wm/compton/Makefile |
Created attachment 195368 [details] the patch