Bug 230043

Summary: sysutils/flashrom: unbreak on aarch64 and others
Product: Ports & Packages Reporter: Val Packett <val>
Component: Individual Port(s)Assignee: Mark Linimon <linimon>
Status: Closed FIXED    
Severity: Affects Only Me CC: linimon, mizhka
Priority: --- Flags: bugzilla: maintainer-feedback? (mizhka)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 201763    
Attachments:
Description Flags
flashrom.patch none

Description Val Packett 2018-07-25 17:27:04 UTC
Created attachment 195452 [details]
flashrom.patch

The DMIDECODE option requires a package that's only available on i386/amd64, so restrict that option to these platforms.

+ aarch64's endianness wasn't detected, added a tiny patch for that.
Comment 1 Val Packett 2018-07-25 19:22:53 UTC
I also wrote a module for spigen support: https://github.com/flashrom/flashrom/pull/53 Probably worth importing as a patch for now
Comment 2 Michael Zhilin freebsd_committer freebsd_triage 2018-10-08 09:07:17 UTC
Greg V,

Sorry for delay! 

Do you test it on armv7 or aarch64? 
AFAIK, Allwinner H3 is armv7... :|
Comment 3 Val Packett 2018-10-08 18:14:04 UTC
(In reply to Michael Zhilin from comment #2)
Build on both, actual operation on armv7 (don't have SPI on my aarch64 machines)
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-11-01 15:17:18 UTC
A commit references this bug:

Author: linimon
Date: Thu Nov  1 15:16:52 UTC 2018
New revision: 483676
URL: https://svnweb.freebsd.org/changeset/ports/483676

Log:
  Unbreak on aarch64 and possibly others.

  PR:		230043
  Submitted by:	greg at unrelenting dot technology
  Approved by:	maintainer

Changes:
  head/sysutils/flashrom/Makefile