Summary: | www/py-requests: Allergic to dns/py-idna>=2.7 (affects all requests dependents, like py-requests-toolbelt) | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Trond Endrestøl <Trond.Endrestol> |
Component: | Individual Port(s) | Assignee: | Kubilay Kocak <koobs> |
Status: | Closed FIXED | ||
Severity: | Affects Many People | CC: | freebsd-bugzilla.bugs, koobs, vas |
Priority: | Normal | Keywords: | regression |
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any | ||
URL: | https://github.com/requests/requests/commit/991e8b76b7a9d21f698b24fa0058d3d5968721bc |
Description
Trond Endrestøl
2018-08-07 08:28:47 UTC
I updated idna in ports r476560. I'll take a look py-requests-toolbet doesn't declare a dependency on idna. py-requests, however does, which contains the "offending" install_requires: 'idna>=2.5,<2.7', Upstream updated the idna dependency to < 2.8 in https://github.com/requests/requests/commit/991e8b76b7a9d21f698b24fa0058d3d5968721bc Can patch that in until an upcoming requests port version update lands requests test suite with idna 2.7: 487 passed, 12 skipped, 1 xfailed, 1 xpassed in 71.15 seconds A commit references this bug: Author: koobs Date: Tue Aug 7 09:11:29 UTC 2018 New revision: 476584 URL: https://svnweb.freebsd.org/changeset/ports/476584 Log: devel/py-requests: Bump pinned idna dependency version py-idna was updated to 2.7 in ports r476560. py-requests had its idna dependency pinned to <2.7. That broke all py-requests dependents. This change backports part of an upstream commit [1] that bumped the dependency. Whisper of a dream: It would be really cool if *_DEPENDS could declare multiple versions in its scheme. We'd pick up these issues much earlier, and be able to declare dependencies more accurately.</pony> [1] https://github.com/requests/requests/commit/991e8b76b7a9d21f698b24fa0058d3d5968721bc PR: 230430 Reported by: <Trond Endrestol ximalas info> Changes: head/www/py-requests/Makefile head/www/py-requests/files/patch-setup.py @Trond Thank you for the report, apologies for the fallout! After updating your ports tree to at least ports r476584, please re-open if the issue is somehow not resolved. *** Bug 230435 has been marked as a duplicate of this bug. *** *** Bug 230447 has been marked as a duplicate of this bug. *** |