Bug 230843
| Summary: | devel/libserialport: Don't open serial ports when enumerating | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Kyle Evans <kevans> | ||||
| Component: | Individual Port(s) | Assignee: | Boris Samorodov <bsam> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | emaste, kevans | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | bsam:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232991 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 225481 | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: bsam Date: Wed Feb 13 21:56:10 UTC 2019 New revision: 492865 URL: https://svnweb.freebsd.org/changeset/ports/492865 Log: devel/libserialport: Don't open serial ports when enumerating PR: 230843 Submitted by: kevans Changes: head/devel/libserialport/Makefile head/devel/libserialport/files/ head/devel/libserialport/files/patch-freebsd.c Committed, thanks! |
Created attachment 196476 [details] svn(1) diff against devel/libserialport This is not needed and toggles DTR on all connected devices whenever it runs, which isn't necessarily great. Replace it instead with just an access(2) check to make sure the devices are readable by the current user, which is generally what the Linux version of this does. We don't tend to create a bunch of redundant cua* nodes, so this works without exception for drivers like the Linux version.