Bug 230843 - devel/libserialport: Don't open serial ports when enumerating
Summary: devel/libserialport: Don't open serial ports when enumerating
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Boris Samorodov
URL:
Keywords: patch
Depends on:
Blocks: 225481
  Show dependency treegraph
 
Reported: 2018-08-23 14:21 UTC by Kyle Evans
Modified: 2019-02-13 21:58 UTC (History)
2 users (show)

See Also:
bsam: maintainer-feedback+


Attachments
svn(1) diff against devel/libserialport (1.18 KB, patch)
2018-08-23 14:21 UTC, Kyle Evans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer 2018-08-23 14:21:17 UTC
Created attachment 196476 [details]
svn(1) diff against devel/libserialport

This is not needed and toggles DTR on all connected devices whenever it runs, which isn't necessarily great. Replace it instead with just an access(2) check to make sure the devices are readable by the current user, which is generally what the Linux version of this does. We don't tend to create a bunch of redundant cua* nodes, so this works without exception for drivers like the Linux version.
Comment 1 commit-hook freebsd_committer 2019-02-13 21:57:05 UTC
A commit references this bug:

Author: bsam
Date: Wed Feb 13 21:56:10 UTC 2019
New revision: 492865
URL: https://svnweb.freebsd.org/changeset/ports/492865

Log:
  devel/libserialport: Don't open serial ports when enumerating

  PR:		230843
  Submitted by:	kevans

Changes:
  head/devel/libserialport/Makefile
  head/devel/libserialport/files/
  head/devel/libserialport/files/patch-freebsd.c
Comment 2 Boris Samorodov freebsd_committer 2019-02-13 21:58:56 UTC
Committed, thanks!