Bug 230951
| Summary: | print/cups-filters: fix rc.d/cups_browsed to handle cups_browsed_flags as expected | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | J.R. Oldroyd <fbsd> | ||||
| Component: | Individual Port(s) | Assignee: | Tijl Coosemans <tijl> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | Flags: | bugzilla:
maintainer-feedback?
(tijl) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Thanks, I'll include it in the next update of the port. A commit references this bug: Author: tijl Date: Fri Dec 14 17:41:41 UTC 2018 New revision: 487453 URL: https://svnweb.freebsd.org/changeset/ports/487453 Log: - Update to 1.21.5. - Fix support for cups_browsed_flags in the cups_browsed rc.d script. The flags were passed to daemon(8) instead of cups_browsed. [1] PR: 230951 [1] Submitted by: J.R. Oldroyd <fbsd@opal.com> [1] Changes: head/print/cups-filters/Makefile head/print/cups-filters/distinfo head/print/cups-filters/files/cups_browsed.in |
Created attachment 196601 [details] replacement for files/cups_browsed.in As it stands, rc.d/cups_browsed invokes /usr/sbin/daemon using the run_rc_command mechanism. Using /usr/sbin/daemon is necessary but the way it is invoked is wrong because rc.d vars like cups_browsed_flags are passed to the /usr/sbin/daemon command and not the /usr/local/sbin/cups-browsed command as expected. Attached file is a replacement for files/cups_browsed.in which defines a cups_browsed_start start_command in the script and handles the cups_browsed_flags variable as expected. Being able to pass command line flags to /usr/local/sbin/cups-browsed is important in order to avoid having to make config changes in /usr/local/etc/cups/cups-browsed.conf on many client systems.