Bug 230971
| Summary: | [maintainer-update] security/gopass: fix build with Go 1.11 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Sascha Holzleiter <sascha> | ||||||
| Component: | Individual Port(s) | Assignee: | Yuri Victorovich <yuri> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | yuri | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
DISTVERSION is wrong. Please don't use GH_TAGNAME, and use a properly qualified git revision name. What exactly is wrong with the DISTVERSION? It's just like example 5.11 in the porter's handbook. I appended the date of the commit used in GH_TAGNAME. We also have to use GH_TAGNAME because there is no new release since this was committed as stated in the initial comment. This is just a quick fix until there is a proper new release. (In reply to Sascha Holzleiter from comment #2) Please see the example of science/qwalk for how DISTVERSION should look like. No manually entered dates are allowed. Created attachment 196672 [details]
gopass go 1.11 build fix, take 2
Ok, now i get it. New patch uploaded.
Committed, thanks! A commit references this bug: Author: yuri Date: Fri Aug 31 16:09:40 UTC 2018 New revision: 478591 URL: https://svnweb.freebsd.org/changeset/ports/478591 Log: security/gopass: Update 1.8.2 -> 1.8.2-2 PR: 230971 Approved by: sascha@root-login.org (maintainer) Changes: head/security/gopass/Makefile head/security/gopass/distinfo |
Created attachment 196634 [details] go 1.11 build fix diff Go 1.11 moved around the CPU feature bits which results in the following error when building gopass: github.com/gopasspw/gopass/vendor/golang.org/x/crypto/blake2b.supportsAVX2: relocation target runtime.support_avx2 not defined github.com/gopasspw/gopass/vendor/golang.org/x/crypto/blake2b.supportsAVX: relocation target runtime.support_avx not defined A fix was committed upstream but there is no new release yet, so this patch uses the specific commit tag until we get a new release. Changelog: Fix build with go 1.11