Bug 230971 - [maintainer-update] security/gopass: fix build with Go 1.11
Summary: [maintainer-update] security/gopass: fix build with Go 1.11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-28 10:36 UTC by Sascha Holzleiter
Modified: 2018-08-31 16:10 UTC (History)
1 user (show)

See Also:

Attachments
go 1.11 build fix diff (1.19 KB, patch)
2018-08-28 10:36 UTC, Sascha Holzleiter 		sascha: maintainer-approval+
Details | Diff
gopass go 1.11 build fix, take 2 (1.05 KB, patch)
2018-08-29 09:49 UTC, Sascha Holzleiter 		sascha: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Holzleiter 2018-08-28 10:36:28 UTC 
Created attachment 196634 [details]
go 1.11 build fix diff

Go 1.11 moved around the CPU feature bits which results in the following error when building gopass:

github.com/gopasspw/gopass/vendor/golang.org/x/crypto/blake2b.supportsAVX2: relocation target runtime.support_avx2 not defined
github.com/gopasspw/gopass/vendor/golang.org/x/crypto/blake2b.supportsAVX: relocation target runtime.support_avx not defined

A fix was committed upstream but there is no new release yet, so this patch uses the specific commit tag until we get a new release.


Changelog: Fix build with go 1.11
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-28 17:59:37 UTC 
DISTVERSION is wrong.
Please don't use GH_TAGNAME, and use a properly qualified git revision name.
Comment 2 Sascha Holzleiter 2018-08-29 00:11:52 UTC 
What exactly is wrong with the DISTVERSION? It's just like example 5.11 in the porter's handbook. I appended the date of the commit used in GH_TAGNAME.

We also have to use GH_TAGNAME because there is no new release since this was committed as stated in the initial comment. This is just a quick fix until there is a proper new release.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-29 00:16:41 UTC 
(In reply to Sascha Holzleiter from comment #2)

Please see the example of science/qwalk for how DISTVERSION should look like.
No manually entered dates are allowed.
Comment 4 Sascha Holzleiter 2018-08-29 09:49:09 UTC 
Created attachment 196672 [details]
gopass go 1.11 build fix, take 2

Ok, now i get it. New patch uploaded.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-31 16:09:44 UTC 
Committed, thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-08-31 16:10:29 UTC 
A commit references this bug:

Author: yuri
Date: Fri Aug 31 16:09:40 UTC 2018
New revision: 478591
URL: https://svnweb.freebsd.org/changeset/ports/478591

Log:
  security/gopass: Update 1.8.2 -> 1.8.2-2

  PR:		230971
  Approved by:	sascha@root-login.org (maintainer)

Changes:
  head/security/gopass/Makefile
  head/security/gopass/distinfo