Bug 233454

Summary: mail/sendmail: remove some extraneous escaping in regex
Product: Ports & Packages Reporter: Kyle Evans <kevans>
Component: Individual Port(s)Assignee: Dirk Meyer <dinoex>
Status: Closed FIXED    
Severity: Affects Only Me CC: kevans
Priority: --- Flags: dinoex: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 229925    
Attachments:
Description Flags
svn(1) diff against the ports tree for libmilter and sendmail none

Description Kyle Evans freebsd_committer freebsd_triage 2018-11-23 21:38:14 UTC 
Created attachment 199499 [details]
svn(1) diff against the ports tree for libmilter and sendmail

(This patch contains the same fix for mail/libmilter as well; I've included both since you maintain both)

Hi,

sendmail and libmilter both use some extraneous escaping of ' in sed expressions. Since ' is an ordinary character in regex-land and it gets passed through as-is from make(1), this is not needed. Ordinary character escapes will be disallowed in a future version of regex(3), so we correct these now in advance of said change.

Thanks,

Kyle Evans
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-11-26 07:04:29 UTC 
A commit references this bug:

Author: dinoex
Date: Mon Nov 26 07:03:48 UTC 2018
New revision: 485925
URL: https://svnweb.freebsd.org/changeset/ports/485925

Log:
  - remove some extraneous escaping in regex
  PR:		233454
  Submitted by:	Kyle Evans

Changes:
  head/mail/libmilter/Makefile
  head/mail/sendmail/Makefile
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2018-11-26 07:06:10 UTC 
looks fine.