Bug 235093
| Summary: | x11/kde5: more GCC fixes | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||||||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-kde (group) <kde> | ||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||
| Severity: | Affects Only Me | CC: | adridg, linimon, pkubaj, tcberner | ||||||||||||||||
| Priority: | --- | Flags: | tcberner:
maintainer-feedback+
|
||||||||||||||||
| Version: | Latest | ||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||
| OS: | Any | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
Moin moin x11-toolkits/plasma5-kdeplasma-addons misses the options definitions, and will require an explicit toggle to CMake so it is not accidentally linked against. mfg Tobias Created attachment 201313 [details]
v2
Is that ok?
Moin moin Could you refresh the patch against the current tree? mfg Tobias Created attachment 201499 [details]
v3
Regenerated.
Created attachment 201551 [details]
v4
Add option to build qtcreator without qt5-webengine.
A commit references this bug: Author: tcberner Date: Fri Feb 8 22:50:26 UTC 2019 New revision: 492466 URL: https://svnweb.freebsd.org/changeset/ports/492466 Log: Fix with build on GCC architectures. PR: 235093 Submitted by: Piotr Kubaj <pkubaj@anongoth.pl> Changes: head/audio/juk/Makefile head/databases/kexi/Makefile head/games/knights/Makefile head/games/ksudoku/Makefile head/graphics/kphotoalbum/Makefile head/graphics/showimage/Makefile head/multimedia/kaffeine/Makefile head/multimedia/phonon-gstreamer/Makefile head/x11/yakuake/Makefile head/x11-fm/krusader2/Makefile Sorry for the timeout :) first batch committed... Created attachment 201927 [details]
new fixes
More fixes (in addition to the older patch).
A commit references this bug: Author: adridg Date: Mon Feb 18 17:59:18 UTC 2019 New revision: 493281 URL: https://svnweb.freebsd.org/changeset/ports/493281 Log: More non-clang, non-x86 fixes. - add compiler:c++11-lang - make WebEngine optional (Second batch of fixes from the same PR) PR: 235093 Submitted by: Piotr Kubaj <pkubaj@anongoth.pl> Changes: head/audio/amarok/Makefile head/audio/amarok/pkg-plist head/games/gcompris-qt/Makefile head/multimedia/kamoso/Makefile First commit added a bogus =true. That was removed in r493318. Thanks for submitting the patches. You forgot about qtcreator. A commit references this bug: Author: tcberner Date: Fri Mar 22 19:18:06 UTC 2019 New revision: 496581 URL: https://svnweb.freebsd.org/changeset/ports/496581 Log: devel/qtcreator: make www/qt5-webengine optional PR: 235093 Submitted by: Piotr Kubaj <pkubaj@anongoth.pl> Changes: head/devel/qtcreator/Makefile head/devel/qtcreator/pkg-plist Should be fixed now :) (In reply to Tobias C. Berner from comment #13) You forgot the pkg-plist part for qtcreator: Index: devel/qtcreator/pkg-plist =================================================================== --- devel/qtcreator/pkg-plist (revision 496781) +++ devel/qtcreator/pkg-plist (working copy) @@ -826,6 +826,8 @@ %%PORTDOCS%%%%DOCSDIR%%/qtcreator-dev/utils-internal-allocatedlayout-data.html %%PORTDOCS%%%%DOCSDIR%%/qtcreator-dev/utils-internal-allocatedlayout-members.html %%PORTDOCS%%%%DOCSDIR%%/qtcreator-dev/utils-internal-allocatedlayout.html +%%NO_QTWEBENGINE%%%%PORTDOCS%%%%DOCSDIR%%/qtcreator-dev/utils-internal-asyncjob-members.html +%%NO_QTWEBENGINE%%%%PORTDOCS%%%%DOCSDIR%%/qtcreator-dev/utils-internal-asyncjob.html %%PORTDOCS%%%%DOCSDIR%%/qtcreator-dev/utils-internal-bestitemtype.html %%PORTDOCS%%%%DOCSDIR%%/qtcreator-dev/utils-internal-colortip-members.html %%PORTDOCS%%%%DOCSDIR%%/qtcreator-dev/utils-internal-colortip.html :) (In reply to Piotr Kubaj from comment #14) Those files were not present for me, that's why I dropped that hunk from your patch. mfg Tobias (In reply to Tobias C. Berner from comment #15) It likely comes from the clangbackend (src/tools/clangbackend) which is not present on your gcc builds. mfg Tobias Created attachment 203185 [details] qtcreator (In reply to Tobias C. Berner from comment #16) Is this patch ok? (In reply to Piotr Kubaj from comment #17) Is it really related to webengine at all? Created attachment 203190 [details] qtcreator v2 (In reply to Tobias C. Berner from comment #18) Yes, it looks like NO_QTWEBENGINE isn't needed. Correct patch attached. A commit references this bug: Author: tcberner Date: Sat Mar 30 21:05:22 UTC 2019 New revision: 497360 URL: https://svnweb.freebsd.org/changeset/ports/497360 Log: devel/qtcreator: fix plist on GCC based architectures PR: 235093 Submitted by: Piotr Kubaj <pkubaj@anongoth.pl> Changes: head/devel/qtcreator/Makefile head/devel/qtcreator/pkg-plist |
Created attachment 201300 [details] patch Add USES=compiler:c++11-lang where it's needed and use webengine only on amd64 and i386 if the port compiles without it. Tested on powerpc64 and amd64. Hardware sponsored by IntegriCloud.