Bug 235311

Summary: www/node: fails to build on non-x86
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Bradley T. Hughes <bhughes>
Status: Closed FIXED    
Severity: Affects Only Me CC: linimon, mikael.urankar
Priority: --- Keywords: needs-patch, regression
Version: LatestFlags: bhughes: maintainer-feedback+
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 234762    

Description Jan Beich freebsd_committer 2019-01-30 10:30:18 UTC
=======================<phase: configure      >============================
===>  Configuring for node-11.7.0_1
WARNING: --openssl-no-asm will result in binaries that do not take advantage
         of modern CPU cryptographic instructions and will therefore be slower.
         Please refer to BUILDING.md
ERROR: --openssl-no-asm is incompatible with --shared-openssl

Build logs:
- 12.0 aarch64: https://ptpb.pw/FcJr
- 12.0 armv6:   https://ptpb.pw/oXIr
- 12.0 armv7:	https://ptpb.pw/6tg9
- 13.0 aarch64: https://ptpb.pw/YJNI
- 13.0 armv7:   https://ptpb.pw/IU46
Comment 2 mikael.urankar 2019-01-30 14:27:57 UTC
see bug #233835, bug #233650 for a possible fix
Comment 3 Jan Beich freebsd_committer 2019-01-30 14:52:55 UTC
I confirm, adding && ${PORT_OPTIONS:MBUNDLED_SSL} to --openssl-no-asm conditional unbreaks my build.
Comment 4 commit-hook freebsd_committer 2019-02-11 18:25:30 UTC
A commit references this bug:

Author: bhughes
Date: Mon Feb 11 18:24:43 UTC 2019
New revision: 492706
URL: https://svnweb.freebsd.org/changeset/ports/492706

Log:
  www/node*: fix build on non-amd64/-i386 when BUNDLED_SSL is unset

  The --openssl-no-asm configure option should only be set
  when BUNDLED_SSL is enabled.

  PR:		235311
  Reported by:	jbeich
  Sponsored by:	Miles AS

Changes:
  head/www/node/Makefile
  head/www/node10/Makefile
  head/www/node6/Makefile
  head/www/node8/Makefile
Comment 5 Bradley T. Hughes freebsd_committer 2019-02-11 18:27:28 UTC
Done! Thanks for the fix, I've applied it to all 4 Node.js ports :)