Bug 236301

Summary: sysutils/py-salt : test=true no longer shows diff output in 2019.2.0
Product: Ports & Packages Reporter: Henrik Hudson <ports>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed Overcome By Events    
Severity: Affects Some People CC: christer.edwards, woodsb02
Priority: --- Flags: woodsb02: maintainer-feedback-
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://github.com/saltstack/salt/issues/51932
Attachments:
Description Flags
port Makefile diff
none
salt/states/file.py patch to allow test=true diff output none

Description Henrik Hudson 2019-03-05 23:40:21 UTC 
Created attachment 202624 [details]
port Makefile diff

There is a regression in 2019.2.0 in that running a 'state.apply' no longer shows the diff output when using 'test=true'.

Discussion here: 
https://github.com/saltstack/salt/issues/51932

The code change was identified in that thread and in backing out that change I'm successfully able to get diff output when using 'test=true'. Upstream has identified this as a regression and the functionality will be added back in.

I've created a patch file and update the port revision.
Comment 1 Henrik Hudson 2019-03-05 23:41:17 UTC 
Created attachment 202625 [details]
salt/states/file.py patch to allow test=true diff output

The patchfile to allow test=true diff output when running state.apply.
Comment 2 Ben Woods freebsd_committer freebsd_triage 2020-03-06 23:11:41 UTC 
Closing this bug as according to the link below this was fixed in 2019.2.1 and the port is now at version 2019.2.2.
https://github.com/saltstack/salt/issues/51932