Bug 236301 - sysutils/py-salt : test=true no longer shows diff output in 2019.2.0
Summary: sysutils/py-salt : test=true no longer shows diff output in 2019.2.0
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-05 23:40 UTC by Henrik Hudson
Modified: 2019-03-06 02:02 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (christer.edwards)


Attachments
port Makefile diff (271 bytes, patch)
2019-03-05 23:40 UTC, Henrik Hudson
no flags Details | Diff
salt/states/file.py patch to allow test=true diff output (821 bytes, text/plain)
2019-03-05 23:41 UTC, Henrik Hudson
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Hudson 2019-03-05 23:40:21 UTC
Created attachment 202624 [details]
port Makefile diff

There is a regression in 2019.2.0 in that running a 'state.apply' no longer shows the diff output when using 'test=true'.

Discussion here: 
https://github.com/saltstack/salt/issues/51932

The code change was identified in that thread and in backing out that change I'm successfully able to get diff output when using 'test=true'. Upstream has identified this as a regression and the functionality will be added back in.

I've created a patch file and update the port revision.
Comment 1 Henrik Hudson 2019-03-05 23:41:17 UTC
Created attachment 202625 [details]
salt/states/file.py patch to allow test=true diff output

The patchfile to allow test=true diff output when running state.apply.