Bug 236654

Summary:	sa (SCSI tape) doesn't show up in devstat
Product:	Base System	Reporter:	Daniel O'Connor <darius>
Component:	kern	Assignee:	freebsd-bugs (Nobody) <bugs>
Status:	Closed Not A Bug
Severity:	Affects Some People	CC:	markj
Priority:	---
Version:	CURRENT
Hardware:	Any
OS:	Any

Description Daniel O'Connor 2019-03-20 06:16:32 UTC

sys/cam/scsi/scsi_sa.c creates a devstat node and calls devstat_start_transaction_bio() but never calls devstat_end_transaction_bio() so nothing ever appears.

I think adding "devstat_end_transaction_bio(softc->device_stats, bp);" at line 2852 (rev 333152) should fix it, but I've been unable to find an opportunity to reboot the machine with the tape drive to test it so it's only been compile tested.

Comment 1 Mark Johnston freebsd_committer

2019-03-20 15:43:01 UTC

(In reply to darius from comment #0)
sadone() calls biofinish(), which calls devstat_end_transaction_bio().

Comment 2 Daniel O'Connor 2019-03-20 20:35:34 UTC

(In reply to Mark Johnston from comment #1)
Ahh thanks, guess I need to work out what the actual reason it doesn't seem to show up in devstat then!