Bug 236654 - sa (SCSI tape) doesn't show up in devstat
Summary: sa (SCSI tape) doesn't show up in devstat
Status: Closed Not A Bug
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-20 06:16 UTC by Daniel O'Connor
Modified: 2019-03-20 20:35 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel O'Connor 2019-03-20 06:16:32 UTC 
sys/cam/scsi/scsi_sa.c creates a devstat node and calls devstat_start_transaction_bio() but never calls devstat_end_transaction_bio() so nothing ever appears.

I think adding "devstat_end_transaction_bio(softc->device_stats, bp);" at line 2852 (rev 333152) should fix it, but I've been unable to find an opportunity to reboot the machine with the tape drive to test it so it's only been compile tested.
Comment 1 Mark Johnston freebsd_committer freebsd_triage 2019-03-20 15:43:01 UTC 
(In reply to darius from comment #0)
sadone() calls biofinish(), which calls devstat_end_transaction_bio().
Comment 2 Daniel O'Connor 2019-03-20 20:35:34 UTC 
(In reply to Mark Johnston from comment #1)
Ahh thanks, guess I need to work out what the actual reason it doesn't seem to show up in devstat then!