Bug 236688

Summary: devel/py-lxml: fix build with GCC-based architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: William Grzybowski <wg>
Status: Closed FIXED    
Severity: Affects Only Me CC: linimon, pkubaj
Priority: --- Flags: bugzilla: maintainer-feedback? (wg)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch
none
different patch for py-lxml none

Description Piotr Kubaj freebsd_committer 2019-03-21 03:32:38 UTC
Created attachment 203020 [details]
patch

py-lxml after last update doesn't build with base GCC because of #pragma GCC diagnostic. Remove those lines when building with base GCC.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-03-21 07:19:44 UTC
Created attachment 203024 [details]
different patch for py-lxml

The patch I have been testing over the last week or so takes a different approach: just asking for an updated version of gcc.  The #pragma logic seemed unclear to me so I felt it best not to try to remove it.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2019-03-21 07:21:23 UTC
fwiw, this affects nearly 300 ports on powerpc64.  If possible, I'd like to see it go in before Q2 is cut.  Thanks.
Comment 3 William Grzybowski freebsd_committer 2019-03-21 12:30:24 UTC
Committed, thanks
Comment 4 commit-hook freebsd_committer 2019-03-21 12:30:29 UTC
A commit references this bug:

Author: wg
Date: Thu Mar 21 12:29:49 UTC 2019
New revision: 496448
URL: https://svnweb.freebsd.org/changeset/ports/496448

Log:
  devel/py-lxml: fix build on gcc-based archs

  PR:		236688
  Submitted by:	linimon
  Reported by:	Piotr Kubaj

Changes:
  head/devel/py-lxml/Makefile