Bug 236688 - devel/py-lxml: fix build with GCC-based architectures
Summary: devel/py-lxml: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-21 03:32 UTC by Piotr Kubaj
Modified: 2019-03-21 12:30 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (wg)


Attachments
patch (464 bytes, patch)
2019-03-21 03:32 UTC, Piotr Kubaj
no flags Details | Diff
different patch for py-lxml (607 bytes, patch)
2019-03-21 07:19 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-03-21 03:32:38 UTC
Created attachment 203020 [details]
patch

py-lxml after last update doesn't build with base GCC because of #pragma GCC diagnostic. Remove those lines when building with base GCC.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-03-21 07:19:44 UTC
Created attachment 203024 [details]
different patch for py-lxml

The patch I have been testing over the last week or so takes a different approach: just asking for an updated version of gcc.  The #pragma logic seemed unclear to me so I felt it best not to try to remove it.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2019-03-21 07:21:23 UTC
fwiw, this affects nearly 300 ports on powerpc64.  If possible, I'd like to see it go in before Q2 is cut.  Thanks.
Comment 3 William Grzybowski freebsd_committer 2019-03-21 12:30:24 UTC
Committed, thanks
Comment 4 commit-hook freebsd_committer 2019-03-21 12:30:29 UTC
A commit references this bug:

Author: wg
Date: Thu Mar 21 12:29:49 UTC 2019
New revision: 496448
URL: https://svnweb.freebsd.org/changeset/ports/496448

Log:
  devel/py-lxml: fix build on gcc-based archs

  PR:		236688
  Submitted by:	linimon
  Reported by:	Piotr Kubaj

Changes:
  head/devel/py-lxml/Makefile