Bug 237781

Summary: ports-mgmt/portlint: whines about IGNORE within .if blocks, even though the IGNORE works there
Product: Ports & Packages Reporter: Larry Rosenman <ler>
Component: Individual Port(s)Assignee: Joe Marcus Clarke <marcus>
Status: Closed Works As Intended    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (marcus)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description Larry Rosenman freebsd_committer 2019-05-08 01:40:58 UTC
I ran portlint against the current sysutils/lsof Makefile, and portlint complains:

⌂115% [ler@borg.lerctr.org:/usr/ports/sysutils/lsof] $ portlint
WARN: Makefile: "IGNORE" has to appear earlier.
0 fatal errors and 1 warning found.
⌂106% [ler@borg.lerctr.org:/usr/ports/sysutils/lsof] $

No matter where I put the .if block, it complains.  If I put it before the
.include <bsd.port.pre.mk>
line, the check fails in poudriere.

As far as I know, the IGNORE doesn't have to be moved for this case (I'm not sure of the exact rules, but this warning is INCORRECT).
Comment 1 Larry Rosenman freebsd_committer 2019-06-30 18:38:58 UTC
Anything?  Anyone?
Comment 2 Joe Marcus Clarke freebsd_committer 2019-06-30 19:07:05 UTC
Sorry, I never saw the original email.  In this case, use "IGNORE+=" to set IGNORE late, and portlint will not complain.  The result will be the same.