Bug 239228

Summary: databases/sqlite3: sqlite3-3.28.0 config interface should restrict READLINES vs READLINEP options
Product: Ports & Packages Reporter: Dennis Clarke <dclarke>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Some People CC: madpilot, pavelivolkov
Priority: --- Flags: linimon: maintainer-feedback? (pavelivolkov)
Version: Latest   
Hardware: amd64   
OS: Any   
Bug Depends on: 248323    
Bug Blocks:    

Description Dennis Clarke 2019-07-15 15:38:37 UTC
The sqlite3-3.28.0 configure interface in ports gives the user multiple
conflicting options for :

    [ ] READLINES    the libreadline from system
    [ ] READLINEP    the GNU libreadline from ports
    [ ] EDITLINE     the BSD libedit from ports

The user should only be able to select one of these otherwise :

====> Two or more enabled options conflict with each other
=====> Option EDITLINE conflicts with READLINES READLINEP (select only one)
=====> Option READLINEP conflicts with READLINES EDITLINE (select only one)
=====> Option READLINES conflicts with READLINEP EDITLINE (select only one)
Config is invalid. Re-edit? [Y/n]
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-07-15 16:30:46 UTC
Fix Summary and notify maintainer.
Comment 2 commit-hook freebsd_committer 2020-08-01 19:14:53 UTC
A commit references this bug:

Author: madpilot
Date: Sat Aug  1 19:14:11 UTC 2020
New revision: 543921
URL: https://svnweb.freebsd.org/changeset/ports/543921

  - Add back REALINEP and READLINES options and make them and LIBEDIT
    option work after r542047 [1]
  - Also add back options descriptions [1]
  - While here make STAT3 and STAT4 options descriptions start with
    uppercase letter [1]
  - Since in r542047 OPTIONS_GROUP_RL was changed to OPTIONS_RADIO_RL
    also bug 239228 can be closed [2]

  PR:		248323 [1], 239228 [2]
  Submitted by:	myself [1], Dennis Clarke <dclarke@blastwave.org> [2]
  Approved by:	maintainer [1]

Comment 3 Guido Falsi freebsd_committer 2020-08-01 19:16:24 UTC
The change to RADIO in r542047 with the fix in r543921 fix the problem described here.