Bug 239356

Summary: audio/mpg123: drop devel/libltdl dependency (not needed since 1.24.0)
Product: Ports & Packages Reporter: Andriy Voskoboinyk <avos>
Component: Individual Port(s)Assignee: Roman Bogorodskiy <novel>
Status: Closed FIXED    
Severity: Affects Many People CC: novel
Priority: --- Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Makefile.diff
none
Compressed poudriere logs none

Description Andriy Voskoboinyk freebsd_committer 2019-07-21 01:07:10 UTC
Created attachment 205953 [details]
Makefile.diff

From the NEWS file in the distfile:

1.24.0:
-------
...
- Using plain dlopen()/LoadLibrary() for opening modules instead of libltdl.
  This also means that --with-module-suffix is gone in configure.
...

As a result, both - dependency and configure argument - were removed from the Makefile and PORTREVISION was updated due to dependency list change.


'portlint -AC' only shows $FreeBSD$ tag and 'PORTREVISION in new port' warnings.

Checked with poudriere in 12.0 i386 + 12.0 amd64 jails, with and without SNDIO option set.
Comment 1 Andriy Voskoboinyk freebsd_committer 2019-07-21 01:11:43 UTC
Created attachment 205954 [details]
Compressed poudriere logs
Comment 2 commit-hook freebsd_committer 2019-07-21 08:35:35 UTC
A commit references this bug:

Author: novel
Date: Sun Jul 21 08:35:08 UTC 2019
New revision: 507040
URL: https://svnweb.freebsd.org/changeset/ports/507040

Log:
  audio/mpg123: drop devel/libltdl dependency

  Starting with mpg123 1.24.0, libltdl is no longer needed,
  so remove the dependency and the corresponding configure
  argument.

  PR:		239356
  Submitted by:	avos

Changes:
  head/audio/mpg123/Makefile
Comment 3 Roman Bogorodskiy freebsd_committer 2019-07-21 08:39:54 UTC
Committed, thanks!