Bug 239356 - audio/mpg123: drop devel/libltdl dependency (not needed since 1.24.0)
Summary: audio/mpg123: drop devel/libltdl dependency (not needed since 1.24.0)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Roman Bogorodskiy
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-07-21 01:07 UTC by Andriy Voskoboinyk
Modified: 2019-07-21 08:39 UTC (History)
1 user (show)

See Also:


Attachments
Makefile.diff (651 bytes, patch)
2019-07-21 01:07 UTC, Andriy Voskoboinyk
no flags Details | Diff
Compressed poudriere logs (14.07 KB, application/x-xz)
2019-07-21 01:11 UTC, Andriy Voskoboinyk
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer 2019-07-21 01:07:10 UTC
Created attachment 205953 [details]
Makefile.diff

From the NEWS file in the distfile:

1.24.0:
-------
...
- Using plain dlopen()/LoadLibrary() for opening modules instead of libltdl.
  This also means that --with-module-suffix is gone in configure.
...

As a result, both - dependency and configure argument - were removed from the Makefile and PORTREVISION was updated due to dependency list change.


'portlint -AC' only shows $FreeBSD$ tag and 'PORTREVISION in new port' warnings.

Checked with poudriere in 12.0 i386 + 12.0 amd64 jails, with and without SNDIO option set.
Comment 1 Andriy Voskoboinyk freebsd_committer 2019-07-21 01:11:43 UTC
Created attachment 205954 [details]
Compressed poudriere logs
Comment 2 commit-hook freebsd_committer 2019-07-21 08:35:35 UTC
A commit references this bug:

Author: novel
Date: Sun Jul 21 08:35:08 UTC 2019
New revision: 507040
URL: https://svnweb.freebsd.org/changeset/ports/507040

Log:
  audio/mpg123: drop devel/libltdl dependency

  Starting with mpg123 1.24.0, libltdl is no longer needed,
  so remove the dependency and the corresponding configure
  argument.

  PR:		239356
  Submitted by:	avos

Changes:
  head/audio/mpg123/Makefile
Comment 3 Roman Bogorodskiy freebsd_committer 2019-07-21 08:39:54 UTC
Committed, thanks!