Bug 239420
| Summary: | devel/crc32c: fix build on big-endian architectures | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | amzo1337 | ||||
| Priority: | --- | Flags: | linimon:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
I see no problem with this. It was quickly made as it was a dependency for Tensorflow which i'm currently working on. A commit references this bug: Author: pkubaj Date: Thu Aug 1 19:12:17 UTC 2019 New revision: 507823 URL: https://svnweb.freebsd.org/changeset/ports/507823 Log: devel/crc32c: fix build on big-endian architectures C++11 compiler is needed: Target "crc32c" requires the language dialect "CXX11" , but CMake does not know the compile flags to use to enable it. Additionally, big-endian code in src/crc32c_read_le.h needs fixing - the value is 64 bits wide, not 32 bits. PR: 239420 Approved by: amzo1337@gmail.com (maintainer), tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D21054 Changes: head/devel/crc32c/Makefile head/devel/crc32c/files/ head/devel/crc32c/files/patch-src_crc32c__read__le.h |
Created attachment 206029 [details] patch C++11 compiler is needed: Target "crc32c" requires the language dialect "CXX11" , but CMake does not know the compile flags to use to enable it. Additionally, big-endian code in src/crc32c_read_le.h needs fixing - the value is 64 bits wide, not 32 bits.