Bug 239630
| Summary: | x11/libxshmfence: prefer SHM_ANON over mksotemp() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-x11 (Nobody) <x11> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | jkim, x11 | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | jkim:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Sorry the rant. I've missed upstream move to GitLab. https://gitlab.freedesktop.org/xorg/lib/libxshmfence/merge_requests/1 Ping. This may help https://forums.freebsd.org/threads/xorg-high-disk-i-o-activity.79398/ Ping. SHM_ANON is for FreeBSD < 13 as later versions have memfd_create. Ping. Ping? LGTM A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f783260c1c4d7bacbb6d36cab209eab28da49d4e commit f783260c1c4d7bacbb6d36cab209eab28da49d4e Author: Jan Beich <jbeich@FreeBSD.org> AuthorDate: 2019-08-03 21:14:43 +0000 Commit: Jan Beich <jbeich@FreeBSD.org> CommitDate: 2021-05-27 03:30:56 +0000 x11/libxshmfence: prefer SHM_ANON over mksotemp() SHM_ANON is faster and more similar to memfd_create() PR: 239630 Approved by: jkim x11/libxshmfence/Makefile | 1 + x11/libxshmfence/files/patch-src__xshmfence_alloc.c | 12 +++++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) |
Created attachment 206257 [details] v1 (has commit message) SHM_ANON is faster and more similar to memfd_create(). Not bothering to upstream because futex/mksotemp fixes didn't get any feedback after 2 years. Patchwork is complete crap for one-off contributors i.e., those humble enough to not annoy everyone on patch maillist why their contribution wasn't reviewed yet. libxshmfence is only used by DRI3, so make sure to define LIBGL_DRI3_ENABLE via environ(7) due to drm-legacy-kmod hacks in mesa-dri and if using xf86-video-intel add Option "DRI" "3" to xorg.conf.