Bug 239739
| Summary: | factor out hardcoding of "clangXYZ" in math/libpgmath | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mark Linimon <linimon> | ||||
| Component: | Individual Port(s) | Assignee: | Johannes M Dieterich <jmd> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | Flags: | jmd:
maintainer-feedback+
|
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 239736 | ||||||
| Attachments: |
|
||||||
LGTM Committed, thanks. |
Created attachment 206391 [details] patch to math/libpgmath/Makefile There are a number of places in the ports tree where the string "clang<version" is called out. When doing the work to identify stale versions of clang tree-wide, these instances cause extra work. Refactor this usage into LLVM_VER. Note: this refactoring causes portlint to complain but IMHO this complication is worth tolerating to help ease maintainability. Tested on: amd64.