Bug 240103
| Summary: | dns/py-tldextract: Add missing dependencies | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Adam Jimerson <vendion> | ||||
| Component: | Individual Port(s) | Assignee: | Dan Langille <dvl> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Flags: | koobs:
maintainer-feedback+
|
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
This patch applies cleanly. It builds fine. NOTE: RUN_DEPENDS are transitive. https://www.freshports.org/www/py-requests-file lists www/py-requests as a RUN_DEPENDS, so dns/py-tldextract doesn't have to. It only needs to mention www/py-requests-file and www/py-requests will be included. I also added the concurrent option from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240030 And I bumped PORTREVISION A commit references this bug: Author: dvl Date: Sun Aug 25 18:26:53 UTC 2019 New revision: 509828 URL: https://svnweb.freebsd.org/changeset/ports/509828 Log: Add RUN_DEPENDS for www/py-requests-file Add USE_PYTHON=concurrent PR: 240103 Submitted by: Adam Jimerson <vendion@gmail.com> Changes: head/dns/py-tldextract/Makefile Committed. Thank you. (In reply to Dan Langille from comment #1) Note: Python ports should depend on any and all dependencies that are declared required by that (Python) package. If its a 'spurious' dependency in the sense that the package code doesn't actually 'use' that package/module, then patch out the dependency (from setup.py) and send it upstream so they can remove it there. (In reply to Kubilay Kocak from comment #4) Ahhh. Should requests-file could drop its dependency on requests, or replace it with something else tldextract would then be broken. Now I follow. After conversation offline, Adam's original patch is more appropriate. I will add in the depends. via testport: root@120amd64-working:~ # pkg info -d py27-tldextract py27-tldextract-2.2.1_2: py27-requests-file-1.4.3 py27-requests-2.21.0 python27-2.7.16_1 py27-idna-2.8 py27-setuptools-41.2.0 root@120amd64-working:~ # A commit references this bug: Author: dvl Date: Mon Aug 26 15:53:03 UTC 2019 New revision: 509956 URL: https://svnweb.freebsd.org/changeset/ports/509956 Log: Add www/py-requests as RUN_DEPENDS PR: 240103 Submitted by: Adam Jimerson <vendion@gmail.com> Changes: head/dns/py-tldextract/Makefile |
Created attachment 206897 [details] Patch to add missing dependencies The patch to update py-tldextract to 2.2.1 was reported as missing some needed dependencies. This patch adds py-requests and py-requests-file to the RUN_DEPENDS.