Bug 240103 - dns/py-tldextract: Add missing dependencies
Summary: dns/py-tldextract: Add missing dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-25 17:28 UTC by Adam Jimerson
Modified: 2019-09-16 12:10 UTC (History)
0 users

See Also:
koobs: maintainer-feedback+

Attachments
Patch to add missing dependencies (594 bytes, patch)
2019-08-25 17:28 UTC, Adam Jimerson 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Jimerson 2019-08-25 17:28:33 UTC 
Created attachment 206897 [details]
Patch to add missing dependencies

The patch to update py-tldextract to 2.2.1 was reported as missing some needed dependencies. This patch adds py-requests and py-requests-file to the RUN_DEPENDS.
Comment 1 Dan Langille freebsd_committer freebsd_triage 2019-08-25 18:20:01 UTC 
This patch applies cleanly. It builds fine.

NOTE: RUN_DEPENDS are transitive.

https://www.freshports.org/www/py-requests-file lists  www/py-requests as a RUN_DEPENDS, so dns/py-tldextract doesn't have to. It only needs to mention www/py-requests-file and www/py-requests will be included.

I also added the concurrent option from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240030

And I bumped PORTREVISION
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-08-25 18:27:17 UTC 
A commit references this bug:

Author: dvl
Date: Sun Aug 25 18:26:53 UTC 2019
New revision: 509828
URL: https://svnweb.freebsd.org/changeset/ports/509828

Log:
  Add RUN_DEPENDS for www/py-requests-file
  Add USE_PYTHON=concurrent

  PR:		240103
  Submitted by:	Adam Jimerson <vendion@gmail.com>

Changes:
  head/dns/py-tldextract/Makefile
Comment 3 Dan Langille freebsd_committer freebsd_triage 2019-08-25 18:30:29 UTC 
Committed. Thank you.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-26 14:00:07 UTC 
(In reply to Dan Langille from comment #1)

Note: Python ports should depend on any and all dependencies that are declared required by that (Python) package. If its a 'spurious' dependency in the sense that the package code doesn't actually 'use' that package/module, then patch out the dependency (from setup.py) and send it upstream so they can remove it there.
Comment 5 Dan Langille freebsd_committer freebsd_triage 2019-08-26 15:03:31 UTC 
(In reply to Kubilay Kocak from comment #4)
Ahhh.

Should requests-file could drop its dependency on requests, or replace it with something else tldextract would then be broken.

Now I follow.
Comment 6 Dan Langille freebsd_committer freebsd_triage 2019-08-26 15:50:17 UTC 
After conversation offline, Adam's original patch is more appropriate.  I will add in the depends.
Comment 7 Dan Langille freebsd_committer freebsd_triage 2019-08-26 15:51:39 UTC 
via testport:

root@120amd64-working:~ # pkg info -d py27-tldextract
py27-tldextract-2.2.1_2:
	py27-requests-file-1.4.3
	py27-requests-2.21.0
	python27-2.7.16_1
	py27-idna-2.8
	py27-setuptools-41.2.0
root@120amd64-working:~ #
Comment 8 commit-hook freebsd_committer freebsd_triage 2019-08-26 15:53:34 UTC 
A commit references this bug:

Author: dvl
Date: Mon Aug 26 15:53:03 UTC 2019
New revision: 509956
URL: https://svnweb.freebsd.org/changeset/ports/509956

Log:
  Add www/py-requests as RUN_DEPENDS

  PR:		240103
  Submitted by:	Adam Jimerson <vendion@gmail.com>

Changes:
  head/dns/py-tldextract/Makefile