Bug 240407

Summary: print/lilypond-devel: Fix fontforge version check
Product: Ports & Packages Reporter: Martin Neubauer <m.ne>
Component: Individual Port(s)Assignee: Niclas Zeising <zeising>
Status: Closed FIXED    
Severity: Affects Many People CC: zeising
Priority: --- Keywords: needs-qa
Version: LatestFlags: m.ne: maintainer-feedback+
koobs: merge-quarterly?
Hardware: Any   
OS: Any   
Attachments:
Description Flags
fixed version check
m.ne: maintainer-approval+
fixed version check m.ne: maintainer-approval+

Description Martin Neubauer 2019-09-08 07:01:20 UTC
Created attachment 207274 [details]
fixed version check

With the latest update to print/fontforge the version check didn't work anymore. The attached patch changes that check to extract the correct version again.
Comment 1 Martin Neubauer 2019-09-08 07:42:38 UTC
Created attachment 207275 [details]
fixed version check

removing BROKEN statement added between creating and submitting the previous patch
Comment 2 Niclas Zeising freebsd_committer freebsd_triage 2019-09-09 16:10:00 UTC
Part of the issue is that fontforge is stupid and tries to open a GUI before parsing options, such as -version, which doesn't need a GUI.  I've submitted a RP for fontconfig for that issue.  This looks like a good interim solution, though.  There is no need to merge it to the Q3 branch, since it's only an issue after the fontforge update.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-09-09 16:54:52 UTC
A commit references this bug:

Author: zeising
Date: Mon Sep  9 16:54:33 UTC 2019
New revision: 511648
URL: https://svnweb.freebsd.org/changeset/ports/511648

Log:
  print/lilypond-devel: Fix configure

  Fix configure script issues detecting fontforge after fontforge update.

  PR:		240407
  Submitted by:	m.ne@gmx.net (maintainer)

Changes:
  head/print/lilypond-devel/Makefile
  head/print/lilypond-devel/files/patch-configure
Comment 4 Niclas Zeising freebsd_committer freebsd_triage 2019-09-09 16:57:30 UTC
Committed, thanks!