Bug 240771

Summary:

[exp-run] Go ports: cleanup, finish transition to USES=go

Product:

Ports & Packages

Reporter:

Dmitri Goutnik <dmgk>

Component:

Ports Framework

Assignee:

Dmitri Goutnik <dmgk>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

ports-bugs

Priority:

---

Flags:

antoine: exp-run+

Version:

Latest

Hardware:

Any

OS:

Any

URL:

https://reviews.freebsd.org/D21741

Attachments:

Description	Flags
D21741_43_44.diff	none
D21741_43_44.diff v2	none
D21741_43_44.diff v3	none
D21741_43_44.diff v4	none

Description Dmitri Goutnik freebsd_committer

2019-09-23 13:03:23 UTC

Created attachment 207741 [details]
D21741_43_44.diff

Go ports: cleanup, finish transition to USES=go started with r505321

- Remove custom build/install targets left in place after r505321
- Switch to the new GO_TARGET tuple syntax introduced in r512001
- Switch to go:modules when upstream already uses them

Attached is a combined patch of review D21741, review D21743 and review D21744

Comment 1 Dmitri Goutnik freebsd_committer

2019-09-23 16:27:02 UTC

Created attachment 207745 [details]
D21741_43_44.diff v2

Fix GO_BUIILDFLAGS typo in editors/micro/Makefile

Comment 2 Dmitri Goutnik freebsd_committer

2019-09-24 19:13:50 UTC

Created attachment 207776 [details]
D21741_43_44.diff v3

Rebase after ports r512743

Comment 3 Antoine Brodin freebsd_committer

2019-09-29 06:29:02 UTC

Can you refresh the patch?

Comment 4 Antoine Brodin freebsd_committer

2019-09-29 06:31:39 UTC

and generate the patch with --show-copies-as-adds

Comment 5 Dmitri Goutnik freebsd_committer

2019-09-29 12:19:30 UTC

Created attachment 207932 [details]
D21741_43_44.diff v4

Regenerated patch

Comment 6 Antoine Brodin freebsd_committer

2019-09-29 19:17:38 UTC

Exp-run looks fine

Comment 7 Dmitri Goutnik freebsd_committer

2019-09-29 22:40:39 UTC

Thanks for the exp-run, committed as ports r513274, ports r513275 and ports r513276