Bug 240771 - [exp-run] Go ports: cleanup, finish transition to USES=go
Summary: [exp-run] Go ports: cleanup, finish transition to USES=go
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitri Goutnik
URL: https://reviews.freebsd.org/D21741
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-23 13:03 UTC by Dmitri Goutnik
Modified: 2019-09-29 22:40 UTC (History)
1 user (show)

See Also:
antoine: exp-run+

Attachments
D21741_43_44.diff (251.83 KB, patch)
2019-09-23 13:03 UTC, Dmitri Goutnik 		no flags Details | Diff
D21741_43_44.diff v2 (251.83 KB, patch)
2019-09-23 16:27 UTC, Dmitri Goutnik 		no flags Details | Diff
D21741_43_44.diff v3 (251.01 KB, patch)
2019-09-24 19:13 UTC, Dmitri Goutnik 		no flags Details | Diff
D21741_43_44.diff v4 (252.72 KB, patch)
2019-09-29 12:19 UTC, Dmitri Goutnik 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2019-09-23 13:03:23 UTC 
Created attachment 207741 [details]
D21741_43_44.diff

Go ports: cleanup, finish transition to USES=go started with r505321

- Remove custom build/install targets left in place after r505321
- Switch to the new GO_TARGET tuple syntax introduced in r512001
- Switch to go:modules when upstream already uses them

Attached is a combined patch of review D21741, review D21743 and review D21744
Comment 1 Dmitri Goutnik freebsd_committer freebsd_triage 2019-09-23 16:27:02 UTC 
Created attachment 207745 [details]
D21741_43_44.diff v2

Fix GO_BUIILDFLAGS typo in editors/micro/Makefile
Comment 2 Dmitri Goutnik freebsd_committer freebsd_triage 2019-09-24 19:13:50 UTC 
Created attachment 207776 [details]
D21741_43_44.diff v3

Rebase after ports r512743
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2019-09-29 06:29:02 UTC 
Can you refresh the patch?
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2019-09-29 06:31:39 UTC 
and generate the patch with --show-copies-as-adds
Comment 5 Dmitri Goutnik freebsd_committer freebsd_triage 2019-09-29 12:19:30 UTC 
Created attachment 207932 [details]
D21741_43_44.diff v4

Regenerated patch
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2019-09-29 19:17:38 UTC 
Exp-run looks fine
Comment 7 Dmitri Goutnik freebsd_committer freebsd_triage 2019-09-29 22:40:39 UTC 
Thanks for the exp-run, committed as ports r513274, ports r513275 and ports r513276