Bug 241237
| Summary: | [NEW PORT] multimedia/kodi-addon-peripheral.joystick-devel: Joystick support for Kodi | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ivan Rozhuk <rozhuk.im> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Only Me | CC: | rozhuk.im | ||||||||||||||
| Priority: | --- | Keywords: | feature, needs-patch, needs-qa | ||||||||||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback?
(rozhuk.im) |
||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241236 | ||||||||||||||||
| Bug Depends on: | 241348 | ||||||||||||||||
| Bug Blocks: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 208296 [details]
patch
Created attachment 208297 [details]
rome noninja
Created attachment 208315 [details]
small changes in lib detect
Please address the problems below.
+PORTNAME= kodi-addon-peripheral-joystick
+PORTVERSION= 1.4.8
+DISTVERSIONPREFIX=v
+CATEGORIES= multimedia
+PKGNAMESUFFIX= -devel
It would be nice if you could set PORTNAME, PKGNAME{PREFIX,SUFFIX}
like I did in multimedia/kodi-addon-inputstream.adaptive-devel and
rename the port dir to multimedia/kodi-addon-peripheral.joystick-devel.
You can also drop GH_PROJECT afterwards. Please copy BUILD_DEPENDS
and RUN_DEPENDS from there too.
+GH_TAGNAME= 7611722a4921b66674a41c3f5322ff0a54246b71
Drop this and DISTVERSIONPREFIX. The repository has a 1.4.8-Leia
tag with that commit already, so:
DISTVERSION= 1.4.8
DISTVERSIONSUFFIX= -Leia
+ @${CP} -f ${FILESDIR}/input.h ${WRKSRC}/src/linux/
+ @${CP} -f ${FILESDIR}/input-event-codes.h ${WRKSRC}/src/linux/
I do not like this at all. Can this port not use evdev-proto instead
of having its own copy of these headers?
Created attachment 208430 [details]
patch
Comment on attachment 208430 [details] patch Looks fine to me from a technical point of view. If you could embellish pkg-descr a little (not just a repeat of COMMENT, 2-3 proper sentences on what this addon does, enables, and that this port is for kodi-devel) that would be perfect. +# Created by: Rozhuk Ivan 2018 - 2019 <rozhuk.im@gmail.com> Usually we discourage adding new "Created by" lines. However this is fine with me if you really want to have it, but I think you should remove the years. The date and your name will already be in the commit log. Created attachment 208454 [details]
patch
A commit references this bug: Author: tobik Date: Wed Nov 27 10:19:31 UTC 2019 New revision: 518491 URL: https://svnweb.freebsd.org/changeset/ports/518491 Log: New port: multimedia/kodi-addon-peripheral.joystick-devel This add-on provides joystick drivers and button mapping services for Kodi. It uses Kodi's Peripheral API. This port is for multimedia/kodi-devel only. WWW: https://github.com/xbmc/peripheral.joystick PR: 241237 Submitted by: rozhuk.im@gmail.com Changes: head/multimedia/Makefile head/multimedia/kodi-addon-peripheral.joystick-devel/ head/multimedia/kodi-addon-peripheral.joystick-devel/Makefile head/multimedia/kodi-addon-peripheral.joystick-devel/distinfo head/multimedia/kodi-addon-peripheral.joystick-devel/files/ head/multimedia/kodi-addon-peripheral.joystick-devel/pkg-descr head/multimedia/kodi-addon-peripheral.joystick-devel/pkg-plist Committed. Thanks! Would be nice to see kodi-addon-peripheral-joystick use evdev-proto too. Can you submit a patch for that? |
Created attachment 208290 [details] patch This is devel version of multimedia/kodi-addon-peripheral-joystick for multimedia/kodi-devel.