Bug 241236 - multimedia/kodi-devel: Install CMake files
Summary: multimedia/kodi-devel: Install CMake files
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2019-10-14 02:39 UTC by Ivan Rozhuk
Modified: 2019-10-14 10:35 UTC (History)
1 user (show)

See Also:
tobik: maintainer-feedback+

Attachments
patch (1.18 KB, patch)
2019-10-14 02:39 UTC, Ivan Rozhuk 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2019-10-14 02:39:07 UTC 
Created attachment 208289 [details]
patch

This files need to able to build various addons.
multimedia/kodi install it, but multimedia/kodi-devel does not.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-10-14 02:41:03 UTC 
MFH Candidate: Make consistent with multimedia/kodi and addons builds/usage
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-10-14 06:02:37 UTC 
> multimedia/kodi install it, but multimedia/kodi-devel does not.

It clearly does install them because your patch just moves them
from share/kodi/cmake to lib/kodi.  This should not be needed
at all.

Changing
+BUILD_DEPENDS=	${LOCALBASE}/lib/kodi/KodiConfig.cmake:multimedia/kodi-devel
into
+BUILD_DEPENDS=	${LOCALBASE}/share/kodi/cmake/KodiConfig.cmake:multimedia/kodi-devel
in peripheral.joystick makes it build as is.
Comment 3 Ivan Rozhuk 2019-10-14 10:08:41 UTC 
Yes, you are right.
But I install kodi-devel and does not see any /usr/local/share/kodi/cmake/ folder, then I look into pkg-plist and see no .cmake files, that is why I add it.

Now I remove /usr/local/share/kodi/cmake/ and reinstall kodi-devel and get .cmake files.
It is very strange: how files that are not in plist get here?
Probably kodi-devel pkg-plist should be updated?
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2019-10-14 10:35:02 UTC 
kodi-devel auto adds everything in share/kodi to the plist via PORTDATA=*.