Bug 241594

Summary: devel/grpc: Update to 1.24.3
Product: Ports & Packages Reporter: Neel Chauhan <nc>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Many People CC: james.wright, swills, tcberner
Priority: --- Keywords: buildisok
Version: LatestFlags: nc: maintainer-feedback+
Hardware: Any   
OS: Any   
Description Flags
Patch (Revision 1) nc: maintainer-approval+

Description Neel Chauhan freebsd_committer 2019-10-30 19:41:00 UTC
Created attachment 208707 [details]
Patch (Revision 1)

Builds on FreeBSD 12.0 amd64.
Comment 1 Automation User 2019-10-30 21:54:49 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/92680784
Comment 2 commit-hook freebsd_committer 2019-11-02 11:47:44 UTC
A commit references this bug:

Author: tcberner
Date: Sat Nov  2 11:47:01 UTC 2019
New revision: 516302
URL: https://svnweb.freebsd.org/changeset/ports/516302

  devel/grpc: Update to 1.24.3

  PR:		241594
  Submitted by:	Neel Chauhan <neel@neelc.org> (maintainer)

Comment 3 Tobias C. Berner freebsd_committer 2019-11-02 12:03:33 UTC
Committed. Thanks.
Comment 4 commit-hook freebsd_committer 2019-11-05 16:26:05 UTC
A commit references this bug:

Author: swills
Date: Tue Nov  5 16:25:34 UTC 2019
New revision: 516808
URL: https://svnweb.freebsd.org/changeset/ports/516808

  devel/grpc: revert r516302

  This update seems to break at least science/py-tensorflow and

  PR:		241594
  Discussed with:	tcberner
  With hat:	portmgr

Comment 5 Steve Wills freebsd_committer 2019-11-05 16:27:57 UTC
Reopen due to revert
Comment 6 James Wright 2019-11-07 21:09:53 UTC
(In reply to commit-hook from comment #4)

It also broke sysutils/apache-mesos, which I patched for the new version, and now breaks due to the reversion back to 1.22.

The fix to mesos for using grpc 1.24 was pretty simple, just a namespace change;

Can we not do the same for py-tensorflow?
Comment 7 commit-hook freebsd_committer 2019-11-20 14:24:24 UTC
A commit references this bug:

Author: lwhsu
Date: Wed Nov 20 14:23:26 UTC 2019
New revision: 518021
URL: https://svnweb.freebsd.org/changeset/ports/518021

  Unbreak by reverting the patch for grpc 1.24, which was downgraded to 1.22 [1]

  PR:		241933, 241594 [1]
  Submitted by:	James Wright <james.wright@digital-chaos.com>

Comment 8 Tobias C. Berner freebsd_committer 2020-03-08 17:36:53 UTC
Moin moin 

Could you respin the update?

mfg Tobias
Comment 9 Mark Linimon freebsd_committer freebsd_triage 2020-09-13 17:41:54 UTC
^Triage: over to current maintainer.
Comment 10 Po-Chuan Hsieh freebsd_committer 2020-12-29 16:22:50 UTC
See https://reviews.freebsd.org/D27752 for grpc 1.34.0 work by jrm@.
Comment 11 Po-Chuan Hsieh freebsd_committer 2021-01-06 13:15:25 UTC
Update to 1.34.0 in r560402. Thanks!