Bug 241922
| Summary: | [PATCH] irc/quassel: Apply OpenLDAP dependency Right Way™ | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dima Panov <fluffy> | ||||
| Component: | Individual Port(s) | Assignee: | Dima Panov <fluffy> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | mat, woodsb02 | ||||
| Priority: | --- | Keywords: | patch, patch-ready | ||||
| Version: | Latest | Flags: | woodsb02:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Comment on attachment 209105 [details]
[PATCH] irc/quassel: Apply OpenLDAP dependency Right Way™
Maintained approved. You ok to commit this?
Can I please request that lowercase is used for OPENLDAP=yes (change to openldap=yes)
A commit references this bug: Author: fluffy Date: Mon Nov 18 12:34:58 UTC 2019 New revision: 517867 URL: https://svnweb.freebsd.org/changeset/ports/517867 Log: - Switch to USE_OPENLDAP framework instead of direct openldap origin hardcode, unbreak OpenLDAP/SASL use PR: 241922 Submitted by: myself Approved by: maintainer (woodsb02) MFH: 2019Q4 Changes: head/irc/quassel/Makefile Committed! A commit references this bug: Author: fluffy Date: Mon Nov 18 14:09:34 UTC 2019 New revision: 517869 URL: https://svnweb.freebsd.org/changeset/ports/517869 Log: MFH: r517867 - Switch to USE_OPENLDAP framework instead of direct openldap origin hardcode, unbreak OpenLDAP/SASL use PR: 241922 Submitted by: myself Approved by: maintainer (woodsb02) Approved by: ports-secteam (joneum) Changes: _U branches/2019Q4/ branches/2019Q4/irc/quassel/Makefile Hi Mat, I was hoping to get your opinion on whether there should be a portlint test for this, to prompt maintainers to use the correct USE_OPENLDAP instead of hard coding dependencies? No, USE_OPENLDAP is going away rather sooner than later. |
Created attachment 209105 [details] [PATCH] irc/quassel: Apply OpenLDAP dependency Right Way™ [PATCH] irc/quassel: Apply OpenLDAP dependency Right Way™ Switch to USE_OPENLDAP framework instead of direct openldap origin hardcode, unbreak OpenLDAP/SASL use