Bug 241922 - [PATCH] irc/quassel: Apply OpenLDAP dependency Right Way™
Summary: [PATCH] irc/quassel: Apply OpenLDAP dependency Right Way™
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dima Panov
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2019-11-12 16:48 UTC by Dima Panov
Modified: 2019-11-18 22:07 UTC (History)
2 users (show)

See Also:
woodsb02: maintainer-feedback+


Attachments
[PATCH] irc/quassel: Apply OpenLDAP dependency Right Way™ (643 bytes, patch)
2019-11-12 16:48 UTC, Dima Panov
woodsb02: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov freebsd_committer 2019-11-12 16:48:15 UTC
Created attachment 209105 [details]
[PATCH] irc/quassel: Apply OpenLDAP dependency Right Way™

[PATCH] irc/quassel: Apply OpenLDAP dependency Right Way™

Switch to USE_OPENLDAP framework instead of direct openldap origin hardcode, unbreak OpenLDAP/SASL use
Comment 1 Ben Woods freebsd_committer 2019-11-18 12:29:13 UTC
Comment on attachment 209105 [details]
[PATCH] irc/quassel: Apply OpenLDAP dependency Right Way™

Maintained approved. You ok to commit this?
Can I please request that lowercase is used for OPENLDAP=yes (change to openldap=yes)
Comment 2 commit-hook freebsd_committer 2019-11-18 12:35:15 UTC
A commit references this bug:

Author: fluffy
Date: Mon Nov 18 12:34:58 UTC 2019
New revision: 517867
URL: https://svnweb.freebsd.org/changeset/ports/517867

Log:
  - Switch to USE_OPENLDAP framework instead of direct openldap origin hardcode, unbreak OpenLDAP/SASL use

  PR:		241922
  Submitted by:	myself
  Approved by:	maintainer (woodsb02)
  MFH:		2019Q4

Changes:
  head/irc/quassel/Makefile
Comment 3 Dima Panov freebsd_committer 2019-11-18 12:37:07 UTC
Committed!
Comment 4 commit-hook freebsd_committer 2019-11-18 14:10:24 UTC
A commit references this bug:

Author: fluffy
Date: Mon Nov 18 14:09:34 UTC 2019
New revision: 517869
URL: https://svnweb.freebsd.org/changeset/ports/517869

Log:
  MFH: r517867

  - Switch to USE_OPENLDAP framework instead of direct openldap origin hardcode, unbreak OpenLDAP/SASL use

  PR:		241922
  Submitted by:	myself
  Approved by:	maintainer (woodsb02)

  Approved by:	ports-secteam (joneum)

Changes:
_U  branches/2019Q4/
  branches/2019Q4/irc/quassel/Makefile
Comment 5 Ben Woods freebsd_committer 2019-11-18 22:07:24 UTC
Hi Mat,
I was hoping to get your opinion on whether there should be a portlint test for this, to prompt maintainers to use the correct USE_OPENLDAP instead of hard coding dependencies?