Summary: | math/cln: fix build on powerpc64 elfv2, simplify port | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||
Component: | Individual Port(s) | Assignee: | Piotr Kubaj <pkubaj> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | wen | ||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(wen) |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Approved as mentor ("does no harm" on ppcports) pending maintainer review. Look fine, please go ahead! Thanks ! wen A commit references this bug: Author: pkubaj Date: Sun Dec 1 12:08:40 UTC 2019 New revision: 518767 URL: https://svnweb.freebsd.org/changeset/ports/518767 Log: math/cln: fix build on powerpc64 elfv2, simplify port powerpc64 elfv2 needs the same patches as arm* and aarch64, but builds without -DNO_ASM. Simplify the port by applying the arm patches everywhere and use CPPFLAGS_${ARCH} instead of .if ${ARCH} block. Build passes on powerpc64 elfv1 fine, so the original issue must have been fixed. PR: 242296 Approved by: wen (maintainer), linimon (mentor) Changes: head/math/cln/Makefile head/math/cln/files/extra-patch-src_base_low_cl__low__div.cc head/math/cln/files/extra-patch-src_base_low_cl__low__mul.cc head/math/cln/files/patch-src_base_low_cl__low__div.cc head/math/cln/files/patch-src_base_low_cl__low__mul.cc |
Created attachment 209526 [details] patch powerpc64 elfv2 needs the same patches as arm* and aarch64, but builds without -DNO_ASM. Simplify the port by applying the arm patches everywhere and use CPPFLAGS_${ARCH} instead of .if ${ARCH} block. Build passes on powerpc64 elfv1 fine, so the original issue must have been fixed.