Bug 242296 - math/cln: fix build on powerpc64 elfv2, simplify port
Summary: math/cln: fix build on powerpc64 elfv2, simplify port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-29 11:34 UTC by Piotr Kubaj
Modified: 2019-12-01 12:09 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (wen)


Attachments
patch (2.80 KB, patch)
2019-11-29 11:34 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (wen)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-11-29 11:34:50 UTC
Created attachment 209526 [details]
patch

powerpc64 elfv2 needs the same patches as arm* and aarch64, but builds without -DNO_ASM. Simplify the port by applying the arm patches everywhere and use CPPFLAGS_${ARCH} instead of .if ${ARCH} block. Build passes on powerpc64 elfv1 fine, so the original issue must have been fixed.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-12-01 06:49:38 UTC
Approved as mentor ("does no harm" on ppcports) pending maintainer review.
Comment 2 Wen Heping freebsd_committer 2019-12-01 07:04:10 UTC
Look fine, please go ahead!
Thanks !

wen
Comment 3 commit-hook freebsd_committer 2019-12-01 12:09:42 UTC
A commit references this bug:

Author: pkubaj
Date: Sun Dec  1 12:08:40 UTC 2019
New revision: 518767
URL: https://svnweb.freebsd.org/changeset/ports/518767

Log:
  math/cln: fix build on powerpc64 elfv2, simplify port

  powerpc64 elfv2 needs the same patches as arm* and aarch64, but builds without -DNO_ASM. Simplify the port by applying the arm patches everywhere and use CPPFLAGS_${ARCH} instead of .if ${ARCH} block. Build passes on powerpc64 elfv1 fine, so the original issue must have been fixed.

  PR:		242296
  Approved by:	wen (maintainer), linimon (mentor)

Changes:
  head/math/cln/Makefile
  head/math/cln/files/extra-patch-src_base_low_cl__low__div.cc
  head/math/cln/files/extra-patch-src_base_low_cl__low__mul.cc
  head/math/cln/files/patch-src_base_low_cl__low__div.cc
  head/math/cln/files/patch-src_base_low_cl__low__mul.cc