Bug 242486

Summary: accessibility/yasr: use patch instead of sed to replace static content
Product: Ports & Packages Reporter: Steve Wills <swills>
Component: Individual Port(s)Assignee: Steve Wills <swills>
Status: Closed FIXED    
Severity: Affects Only Me CC: david.k.gerry
Priority: --- Keywords: buildisok
Version: LatestFlags: bugzilla: maintainer-feedback? (david.k.gerry)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch to remove reinplace none

Description Steve Wills freebsd_committer freebsd_triage 2019-12-06 17:13:13 UTC
Created attachment 209761 [details]
patch to remove reinplace

Per section 4.4.3 of the Porters Handbook, REINPLACE_CMD (sed) should not be used to replace static content. See attached patch.
Comment 1 Automation User 2019-12-06 17:31:31 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/101266498
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-01-06 13:56:48 UTC
A commit references this bug:

Author: swills
Date: Mon Jan  6 13:56:32 UTC 2020
New revision: 522231
URL: https://svnweb.freebsd.org/changeset/ports/522231

Log:
  accessibility/yasr: use patch instead of sed to replace static content

  PR:		242486
  Approved by:	maintainer timeout (david.k.gerry@gmail.com, >3 weeks)

Changes:
  head/accessibility/yasr/Makefile
  head/accessibility/yasr/files/patch-yasr.conf
Comment 3 Steve Wills freebsd_committer freebsd_triage 2020-01-06 13:57:56 UTC
Committed, thanks!