Bug 242486 - accessibility/yasr: use patch instead of sed to replace static content
Summary: accessibility/yasr: use patch instead of sed to replace static content
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2019-12-06 17:13 UTC by Steve Wills
Modified: 2020-01-06 13:57 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (david.k.gerry)


Attachments
patch to remove reinplace (1.02 KB, patch)
2019-12-06 17:13 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer 2019-12-06 17:13:13 UTC
Created attachment 209761 [details]
patch to remove reinplace

Per section 4.4.3 of the Porters Handbook, REINPLACE_CMD (sed) should not be used to replace static content. See attached patch.
Comment 1 Automation User 2019-12-06 17:31:31 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/101266498
Comment 2 commit-hook freebsd_committer 2020-01-06 13:56:48 UTC
A commit references this bug:

Author: swills
Date: Mon Jan  6 13:56:32 UTC 2020
New revision: 522231
URL: https://svnweb.freebsd.org/changeset/ports/522231

Log:
  accessibility/yasr: use patch instead of sed to replace static content

  PR:		242486
  Approved by:	maintainer timeout (david.k.gerry@gmail.com, >3 weeks)

Changes:
  head/accessibility/yasr/Makefile
  head/accessibility/yasr/files/patch-yasr.conf
Comment 3 Steve Wills freebsd_committer 2020-01-06 13:57:56 UTC
Committed, thanks!