Bug 243185
| Summary: | Remove the legacy way of passing Python version, before flavors were a thing. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mathieu Arnold <mat> | ||||||||
| Component: | Ports Framework | Assignee: | Port Management Team <portmgr> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | ports-bugs | ||||||||
| Priority: | --- | Flags: | antoine:
exp-run+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | https://reviews.freebsd.org/D23084 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 242614 | ||||||||||
| Attachments: |
|
||||||||||
This can be committed without an exp-run. Yeah, I thought that the exp-run would not add anything just after I opened the bug report. The thing is, I am wondering how to figure out what will break without this. Created attachment 210532 [details]
v2
After a bit more thoughts, simplify all the code now that PYTHON_VERSION is not a thing we can inherit.
Created attachment 210535 [details]
v3
Bit more stuff.
A commit references this bug: Author: mat Date: Thu Jan 9 13:32:55 UTC 2020 New revision: 522485 URL: https://svnweb.freebsd.org/changeset/ports/522485 Log: Remove the legacy way of passing Python version. This was used before flavors were a thing to make sure if you built port A with some python version, and it needed port B, port B would also be built with the same python version. PR: 243185 Reviewed by: antoine Differential Revision: https://reviews.freebsd.org/D23084 Changes: head/Mk/Uses/python.mk A commit references this bug: Author: mat Date: Thu Jan 9 13:33:01 UTC 2020 New revision: 522487 URL: https://svnweb.freebsd.org/changeset/ports/522487 Log: Cleanup after removing PYTHON_VERSION from DEPENDS_ARGS. Much of the Python version selection code had compat shims around to accomodate the transition from before to with flavors. These can now be removed. PR: 243185 Reviewed by: antoine Differential Revision: https://reviews.freebsd.org/D23084 Changes: head/Mk/Uses/python.mk |
Created attachment 210527 [details] v1