Bug 244345

Summary: devel/ghidra: Install /usr/local/share/ghidra/support/launch.properties as a @sample file
Product: Ports & Packages Reporter: Mateusz Piotrowski <0mp>
Component: Individual Port(s)Assignee: Vladimir Druzenko <vvd>
Status: Closed FIXED    
Severity: Affects Some People CC: sghctoma, tommi.pernila, vvd
Priority: --- Flags: bugzilla: maintainer-feedback? (sghctoma)
Version: Latest   
Hardware: Any   
OS: Any   

Description Mateusz Piotrowski freebsd_committer freebsd_triage 2020-02-23 19:58:27 UTC 
I was looking for a way to start Ghidra with a non-default JDK and found out that it is possible by overriding some defaults in the /usr/local/share/ghidra/support/launch.properties file.

Would it be possible to install this file as /usr/local/share/ghidra/support/launch.properties.sample and mark it with @sample in pkg-plist so that user modification are not overwritten by an package update?

More on the @sample keyword: https://www.freebsd.org/doc/en/books/porters-handbook/book.html#plist-keywords-sample
Comment 1 Tamas Szakaly 2020-02-26 07:42:00 UTC 
Thank you, this seems like a good idea!
I've just realized I'm also behind with two minor versions (we have 9.1 and the most recent is 9.1.2), so I think I'll make this change with the updated version.
Comment 2 TommiP 2020-05-06 10:48:26 UTC 
Hi Tamas,

do you need help testing the new version (9.1.2)?
[Don't want to open up a new bug just for a version update]
Comment 3 TommiP 2020-08-19 12:36:11 UTC 
(In reply to Tamas Szakaly from comment #1)
Hi Tamas,

do you need help with testing the new version 9.1.2?

Br,

Tommi
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-08-19 12:53:37 UTC 
(In reply to TommiP from comment #2)

It might be a good idea to open a new PR so that we could commit the update in case of a maintainer timeout.
Comment 5 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-01-20 12:48:09 UTC 
I am not working on it at the moment. Return to the pool.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-07-26 20:41:21 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e2b8d2a6176627276e35eb607d81bf3e474e41f4

commit e2b8d2a6176627276e35eb607d81bf3e474e41f4
Author:     gatekeeper <tiago.gasiba@gmail.com>
AuthorDate: 2024-07-26 20:31:11 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-26 20:39:31 +0000

    devel/ghidra: update 9.1 → 11.1.2, take maintainership

    Port was FORBIDDEN, updated last time in 2019, maintainer is innactive.
    Tamas Szakaly <sghctoma@gmail.com>, thanks for you work, hope you come
    back to FreeBSD porters team!

    Install share/ghidra/support/launch.properties as a @sample file.

    Changelogs:
    https://htmlpreview.github.io/?https://raw.githubusercontent.com/NationalSecurityAgency/ghidra/Ghidra_11.1.2_build/Ghidra/Configurations/Public_Release/src/global/docs/ChangeHistory.html

    PR:     280378 275383 244345
    MFH:    2024Q3

 devel/ghidra/Makefile                              |  133 +-
 devel/ghidra/distinfo                              |   16 +-
 .../files/patch-GPL_CabExtract_build.gradle (gone) |   18 -
 .../patch-GPL_DemanglerGnu_build.gradle (gone)     |   31 -
 ...tch-GPL_GnuDisassembler_buildGdis.gradle (gone) |   32 -
 devel/ghidra/files/patch-GPL_gpl.gradle (gone)     |   23 -
 .../files/patch-GPL_nativeBuildProperties.gradle   |   31 +-
 ...draBuild_Skeleton_certification.manifest (gone) |   10 -
 ...raBuild_Skeleton_os_freebsd64_README.txt (gone) |    6 -
 ...-Ghidra_Features_Decompiler_build.gradle (gone) |   28 -
 ...es_Decompiler_src_decompile_cpp_Makefile (gone) |   13 -
 ...iler_src_decompile_cpp_loadimage__bfd.hh (gone) |   12 -
 ...res_Decompiler_src_decompile_cpp_types.h (gone) |   39 -
 ...-Ghidra_Features_FunctionID_build.gradle (gone) |   33 -
 ...main_java_ghidra_framework_Platform.java (gone) |   36 -
 ...va_ghidra_framework_OperatingSystem.java (gone) |   10 -
 ...a_RuntimeScripts_Linux_support_launch.sh (gone) |   10 -
 ...patch-Ghidra_RuntimeScripts_build.gradle (gone) |   11 -
 devel/ghidra/files/patch-README.txt (gone)         |    6 -
 devel/ghidra/files/patch-build.gradle (gone)       |   74 -
 .../patch-gradle_root_distribution.gradle (gone)   |   10 -
 .../files/patch-gradle_support_ip.gradle (gone)    |   11 -
 devel/ghidra/pkg-plist (new)                       | 4666 ++++++++++++++++++++
 23 files changed, 4731 insertions(+), 528 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-07-26 20:44:25 UTC 
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a345c2f858e04f01d7c5d6c7c42af76a9898197a

commit a345c2f858e04f01d7c5d6c7c42af76a9898197a
Author:     gatekeeper <tiago.gasiba@gmail.com>
AuthorDate: 2024-07-26 20:31:11 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-26 20:43:34 +0000

    devel/ghidra: update 9.1 → 11.1.2, take maintainership

    Port was FORBIDDEN, updated last time in 2019, maintainer is innactive.
    Tamas Szakaly <sghctoma@gmail.com>, thanks for you work, hope you come
    back to FreeBSD porters team!

    Install share/ghidra/support/launch.properties as a @sample file.

    Changelogs:
    https://htmlpreview.github.io/?https://raw.githubusercontent.com/NationalSecurityAgency/ghidra/Ghidra_11.1.2_build/Ghidra/Configurations/Public_Release/src/global/docs/ChangeHistory.html

    PR:     280378 275383 244345
    MFH:    2024Q3
    (cherry picked from commit e2b8d2a6176627276e35eb607d81bf3e474e41f4)

 devel/ghidra/Makefile                              |  133 +-
 devel/ghidra/distinfo                              |   16 +-
 .../files/patch-GPL_CabExtract_build.gradle (gone) |   18 -
 .../patch-GPL_DemanglerGnu_build.gradle (gone)     |   31 -
 ...tch-GPL_GnuDisassembler_buildGdis.gradle (gone) |   32 -
 devel/ghidra/files/patch-GPL_gpl.gradle (gone)     |   23 -
 .../files/patch-GPL_nativeBuildProperties.gradle   |   31 +-
 ...draBuild_Skeleton_certification.manifest (gone) |   10 -
 ...raBuild_Skeleton_os_freebsd64_README.txt (gone) |    6 -
 ...-Ghidra_Features_Decompiler_build.gradle (gone) |   28 -
 ...es_Decompiler_src_decompile_cpp_Makefile (gone) |   13 -
 ...iler_src_decompile_cpp_loadimage__bfd.hh (gone) |   12 -
 ...res_Decompiler_src_decompile_cpp_types.h (gone) |   39 -
 ...-Ghidra_Features_FunctionID_build.gradle (gone) |   33 -
 ...main_java_ghidra_framework_Platform.java (gone) |   36 -
 ...va_ghidra_framework_OperatingSystem.java (gone) |   10 -
 ...a_RuntimeScripts_Linux_support_launch.sh (gone) |   10 -
 ...patch-Ghidra_RuntimeScripts_build.gradle (gone) |   11 -
 devel/ghidra/files/patch-README.txt (gone)         |    6 -
 devel/ghidra/files/patch-build.gradle (gone)       |   74 -
 .../patch-gradle_root_distribution.gradle (gone)   |   10 -
 .../files/patch-gradle_support_ip.gradle (gone)    |   11 -
 devel/ghidra/pkg-plist (new)                       | 4666 ++++++++++++++++++++
 23 files changed, 4731 insertions(+), 528 deletions(-)