Summary: | databases/kyototycoon: Remove CPU-specific optimisation | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Dave Cottlehuber <dch> | ||||
Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Many People | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) koobs: merge-quarterly? |
||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
@Dave As ports should not produce build machine specific code, this change is: Approved by: portmgr (blanket: ports/framework compliance) The defacto mechanism for this is "-native removal" as has been done in the patch, but also using OPTIMIZED_CFLAGS option (in bsd.options.desc.mk already) which then adds -OX etc etc. If there are any other optimizations done, they shoudl also be removed Comment on attachment 212675 [details]
swap out native optimisation for O3
Approved by: portmgr (blanket: ports/framework compliance)
Pending QA
Committed. Thanks! A commit references this bug: Author: sunpoet Date: Tue Mar 31 23:19:16 UTC 2020 New revision: 530181 URL: https://svnweb.freebsd.org/changeset/ports/530181 Log: Replace CPU-specific optimization (-march=native) with -O3 - Bump PORTREVISION for package change PR: 245032 Submitted by: dch Changes: head/databases/kyototycoon/Makefile head/databases/kyototycoon/files/patch-configure |
Created attachment 212675 [details] swap out native optimisation for O3 depending on the specific cpu stepping for the poudriere build server vs the actual deployed server, some optimisations produce a SIGILL on startup, or elsewhere such as during snapshots. This is very frustrating for a database to dump core and lose all data. Testing: 11.3R and 12.1R and 13.0R all amd64 are fine.